Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2712913002: [WebAgentsAPI]: Split overload set functions into their own module. (Closed)

Created:
3 years, 10 months ago by dglazkov
Modified:
3 years, 10 months ago
Reviewers:
haraken, bashi, Yuki
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[WebAgentsAPI]: Split overload set functions into their own module. This is a part of adapting common overload set resolution for both JS and C++ bindings. BUG=683743 R=bashi,yuki,haraken Review-Url: https://codereview.chromium.org/2712913002 Cr-Commit-Position: refs/heads/master@{#452759} Committed: https://chromium.googlesource.com/chromium/src/+/dded9758efbb26c683ca211a4e74b1b085537fc1

Patch Set 1 #

Total comments: 1

Patch Set 2 : Feedback addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -128 lines) Patch
A third_party/WebKit/Source/bindings/scripts/overload_set_algorithm.py View 1 1 chunk +128 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/bindings/scripts/v8_interface.py View 1 5 chunks +4 lines, -128 lines 0 comments Download

Messages

Total messages: 18 (12 generated)
dglazkov
PTAL.
3 years, 10 months ago (2017-02-23 15:09:53 UTC) #5
haraken
LGTM https://codereview.chromium.org/2712913002/diff/1/third_party/WebKit/Source/bindings/scripts/overload_set.py File third_party/WebKit/Source/bindings/scripts/overload_set.py (right): https://codereview.chromium.org/2712913002/diff/1/third_party/WebKit/Source/bindings/scripts/overload_set.py#newcode1 third_party/WebKit/Source/bindings/scripts/overload_set.py:1: # Copyright 2017 The Chromium Authors. All rights ...
3 years, 10 months ago (2017-02-23 21:38:17 UTC) #6
dglazkov
Feedback addressed.
3 years, 10 months ago (2017-02-24 03:55:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712913002/20001
3 years, 10 months ago (2017-02-24 05:16:58 UTC) #14
bashi
lgtm. Thank you for the refactoring!
3 years, 10 months ago (2017-02-24 05:21:01 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 05:22:43 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dded9758efbb26c683ca211a4e74...

Powered by Google App Engine
This is Rietveld 408576698