[Chromecast] Add new volume control API to CastMediaShlib

chromecast/public/avsettings.h

Index: chromecast/public/avsettings.h
diff --git a/chromecast/public/avsettings.h b/chromecast/public/avsettings.h
index 0b99842bfc3c48fa2d961643503d08593f978985..1cff09858f37e670239f4113e2b963cc927470ad 100644
--- a/chromecast/public/avsettings.h
+++ b/chromecast/public/avsettings.h
@@ -73,6 +73,7 @@ class AvSettings {
     // Initialize() was called.
     ACTIVE_STATE_CHANGED = 0,
 
+    // DEPRECATED - Prefer to implement volume control in CastMediaShlib.

[halliwell, 2017/02/24 21:37:21]

What is OEM supposed to do with this info?  What is the deprecation plan?

[kmackay, 2017/02/24 23:53:29]

Well... we haven't really figured out what the plan is for TVs yet. Ideally they
would implement the new API (maybe TVs won't need to support all content types,
depending on how we do it). Once all OEMs have implemented the new API, we can
remove the old API and stop calling it internally.

[halliwell, 2017/02/25 00:43:46]

Ok.  So can an OEM assume that if they implement the new functions, we will stop
calling these ones?  It could be useful to explain that to them for when they
are doing the update work.

[kmackay, 2017/02/25 02:01:08]

Yes, if they implement the new API, the code will automatically stop calling the
old API.

     // This event shall be fired whenever the system volume level or muted state
     // are changed including when user changed volume via a remote controller,
     // or after a call to SetAudioVolume() or SetAudioMuted().
@@ -203,19 +204,23 @@ class AvSettings {
   //  - UNKNOWN_VOLUME: 0.01 (1%)
   virtual bool GetAudioVolumeStepInterval(float* step_inteval) = 0;
 
+  // DEPRECATED - Prefer to implement volume control in CastMediaShlib.
   // Returns the current volume level, which must be from 0.0 (inclusive) to
   // 1.0 (inclusive).
   virtual float GetAudioVolume() = 0;
 
+  // DEPRECATED - Prefer to implement volume control in CastMediaShlib.
   // Sets new volume level of the device (or HDMI sinks). |level| is from 0.0
   // (inclusive) to 1.0 (inclusive).
   // If successful and the level has changed, it must return true and fire
   // AUDIO_VOLUME_CHANGED.
   virtual bool SetAudioVolume(float level) = 0;
 
+  // DEPRECATED - Prefer to implement volume control in CastMediaShlib.
   // Whether or not the device (or HDMI sinks) is muted.
   virtual bool IsAudioMuted() = 0;
 
+  // DEPRECATED - Prefer to implement volume control in CastMediaShlib.
   // Sets the device (or HDMI sinks) muted.
   // If successful and the muted state has changed, it must return true and fire
   // AUDIO_VOLUME_CHANGED.