[Chromecast] Add new volume control API to CastMediaShlib

chromecast/public/avsettings.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROMECAST_PUBLIC_AVSETTINGS_H_
 #define CHROMECAST_PUBLIC_AVSETTINGS_H_
 
 #include <stdint.h>
 
 #include "output_restrictions.h"
@@ skipping 55 matching lines @@
   enum Event {
     // This event shall be fired whenever the active state is changed including
     // when the screen turned on, when the cast receiver (or the device where
     // cast receiver is running on) became the active input source, or after a
     // call to TurnActive() or TurnStandby().
     // WakeSystem() may change the active state depending on implementation.
     // On this event, GetActiveState() will be called on the thread where
     // Initialize() was called.
     ACTIVE_STATE_CHANGED = 0,
 
+    // DEPRECATED - Prefer to implement volume control in CastMediaShlib.

[halliwell, 2017/02/24 21:37:21]

What is OEM supposed to do with this info?  What is the deprecation plan?

[kmackay, 2017/02/24 23:53:29]

Well... we haven't really figured out what the plan is for TVs yet. Ideally they
would implement the new API (maybe TVs won't need to support all content types,
depending on how we do it). Once all OEMs have implemented the new API, we can
remove the old API and stop calling it internally.

[halliwell, 2017/02/25 00:43:46]

Ok.  So can an OEM assume that if they implement the new functions, we will stop
calling these ones?  It could be useful to explain that to them for when they
are doing the update work.

[kmackay, 2017/02/25 02:01:08]

Yes, if they implement the new API, the code will automatically stop calling the
old API.

     // This event shall be fired whenever the system volume level or muted state
     // are changed including when user changed volume via a remote controller,
     // or after a call to SetAudioVolume() or SetAudioMuted().
     // On this event, GetAudioVolume() and IsAudioMuted() will be called on
     // the thread where Initialize() was called.
     AUDIO_VOLUME_CHANGED = 1,
 
     // This event shall be fired whenever the audio codecs supported by the
     // device (or HDMI sinks connected to the device) are changed.
     // On this event, GetAudioCodecsSupported() and GetMaxAudioChannels() will
@@ skipping 110 matching lines @@
   // interval is specified by platform; returns false if interval should defer
   // to default values.
   //
   // Current default volume step intervals per control type are as follows:
   //  - MASTER_VOLUME: 0.05 (5%)
   //  - ATTENUATION_VOLUME: 0.02 (2%)
   //  - FIXED_VOLUME: 0.01 (1%)
   //  - UNKNOWN_VOLUME: 0.01 (1%)
   virtual bool GetAudioVolumeStepInterval(float* step_inteval) = 0;
 
+  // DEPRECATED - Prefer to implement volume control in CastMediaShlib.
   // Returns the current volume level, which must be from 0.0 (inclusive) to
   // 1.0 (inclusive).
   virtual float GetAudioVolume() = 0;
 
+  // DEPRECATED - Prefer to implement volume control in CastMediaShlib.
   // Sets new volume level of the device (or HDMI sinks). |level| is from 0.0
   // (inclusive) to 1.0 (inclusive).
   // If successful and the level has changed, it must return true and fire
   // AUDIO_VOLUME_CHANGED.
   virtual bool SetAudioVolume(float level) = 0;
 
+  // DEPRECATED - Prefer to implement volume control in CastMediaShlib.
   // Whether or not the device (or HDMI sinks) is muted.
   virtual bool IsAudioMuted() = 0;
 
+  // DEPRECATED - Prefer to implement volume control in CastMediaShlib.
   // Sets the device (or HDMI sinks) muted.
   // If successful and the muted state has changed, it must return true and fire
   // AUDIO_VOLUME_CHANGED.
   virtual bool SetAudioMuted(bool muted) = 0;
 
   // Gets audio codecs supported by the device (or HDMI sinks).
   // The result is an integer of OR'ed AudioCodec values.
   virtual int GetAudioCodecsSupported() = 0;
 
   // Gets maximum number of channels for given audio codec, |codec|.
@@ skipping 94 matching lines @@
   // the current HDMI mode.  Returns false otherwise.
   //
   // Non-HDMI devices should return false.
   virtual bool IsHdrOutputSupportedByCurrentHdmiVideoMode(
       HdrOutputType output_type) = 0;
 };
 
 }  // namespace chromecast
 
 #endif  // CHROMECAST_PUBLIC_AVSETTINGS_H_