Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2712883002: Refresh Public Suffic List to the latest version (Closed)

Created:
3 years, 10 months ago by Ryan Sleevi
Modified:
3 years, 10 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, cbentzel+watch_chromium.org, bnc+watch_chromium.org, net-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refresh Public Suffic List to the latest version This updates from revision 48ff55eab9b82ebc88762eed45277448d1f4f79 (2016-11-29) to revision 1b9ceb762bda9cba75066b8be3c73aed634fd82f (2017-02-23) R=pkasting@chromium.org BUG=686800 Review-Url: https://codereview.chromium.org/2712883002 Cr-Commit-Position: refs/heads/master@{#452364} Committed: https://chromium.googlesource.com/chromium/src/+/5c1bebe6f6414018d36df6bc8429c346562dfd7c

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+260 lines, -340 lines) Patch
M net/base/registry_controlled_domains/effective_tld_names.dat View 13 chunks +154 lines, -183 lines 2 comments Download
M net/base/registry_controlled_domains/effective_tld_names.gperf View 131 chunks +106 lines, -157 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Ryan Sleevi
3 years, 10 months ago (2017-02-23 01:00:13 UTC) #2
Peter Kasting
LGTM https://codereview.chromium.org/2712883002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (left): https://codereview.chromium.org/2712883002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#oldcode5694 net/base/registry_controlled_domains/effective_tld_names.dat:5694: adygeya.ru Wow, none of these are TLDs anymore? ...
3 years, 10 months ago (2017-02-23 01:09:21 UTC) #3
Ryan Sleevi
https://codereview.chromium.org/2712883002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat File net/base/registry_controlled_domains/effective_tld_names.dat (left): https://codereview.chromium.org/2712883002/diff/1/net/base/registry_controlled_domains/effective_tld_names.dat#oldcode5694 net/base/registry_controlled_domains/effective_tld_names.dat:5694: adygeya.ru On 2017/02/23 01:09:20, Peter Kasting (backlogged) wrote: > ...
3 years, 10 months ago (2017-02-23 01:41:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712883002/1
3 years, 10 months ago (2017-02-23 01:41:57 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 03:04:30 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5c1bebe6f6414018d36df6bc8429...

Powered by Google App Engine
This is Rietveld 408576698