Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 2712843004: [DevTools] prepare getPossibleBreakpoints before rolling V8 (Closed)

Created:
3 years, 10 months ago by kozy
Modified:
3 years, 10 months ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] prepare getPossibleBreakpoints before rolling V8 New V8 will contain new flag for Debugger.getPossibleBreakpoints method, so replaced agent method call with invoke to make closure compiler happy during rolling. BUG=chromium:695236 R=dgozman@chromium.org Review-Url: https://codereview.chromium.org/2712843004 Cr-Commit-Position: refs/heads/master@{#452669} Committed: https://chromium.googlesource.com/chromium/src/+/c32079e66898f3d463f9ac8d83e16a119382a84b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
kozy
Dmitry, please take a look.
3 years, 10 months ago (2017-02-23 16:53:24 UTC) #2
dgozman
lgtm
3 years, 10 months ago (2017-02-23 18:19:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712843004/1
3 years, 10 months ago (2017-02-23 21:36:42 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 23:20:41 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c32079e66898f3d463f9ac8d83e1...

Powered by Google App Engine
This is Rietveld 408576698