Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 2712843002: media: Add DecoderConfigType in DecoderStreamTraits (Closed)

Created:
3 years, 10 months ago by xhwang
Modified:
3 years, 10 months ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Add DecoderConfigType in DecoderStreamTraits Add a function in DecoderStreamTraits to return the corresponding DecoderConfigType, so that we can pass in the config to Decoder::Initialize() instead of the whole stream. This is a trivial refactoring which makes sense by itself since decoders should not talk to DemuxerStream directly. Also, this will make supporting switch from clear to encrypted stream easier (in a later CL). BUG=597443 TEST=No functionality change. Review-Url: https://codereview.chromium.org/2712843002 Cr-Commit-Position: refs/heads/master@{#452325} Committed: https://chromium.googlesource.com/chromium/src/+/4f6b7bc7f2da4ae1813936fb341d4ed9ecbaeee8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -14 lines) Patch
M media/filters/decoder_selector.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M media/filters/decoder_stream.cc View 1 chunk +2 lines, -1 line 0 comments Download
M media/filters/decoder_stream_traits.h View 5 chunks +10 lines, -2 lines 0 comments Download
M media/filters/decoder_stream_traits.cc View 4 chunks +22 lines, -9 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
xhwang
Dale: A trivial CL for your review. PTAL
3 years, 10 months ago (2017-02-23 01:02:42 UTC) #4
DaleCurtis
lgtm
3 years, 10 months ago (2017-02-23 01:13:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712843002/1
3 years, 10 months ago (2017-02-23 01:15:09 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 01:21:07 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4f6b7bc7f2da4ae1813936fb341d...

Powered by Google App Engine
This is Rietveld 408576698