Stop SpellCheckProvider from deciding typing progress

Stop SpellCheckProvider from deciding typing progress

In order not to check spelling in the middle of typing a word,
SpellCheckProvider used to decide the typing process, which is
a job that it can't reliably accomplish due to lack of information.

Now that the Blink-side SpellChecker class is no longer sending
spell check requests in the middle of typing a word, there is no
need for SpellCheckProvider to perform the check. Hence, this patch
removes the related code from SpellCheckProvider, and modifies
tests accordingly.

BUG=635504
TEST=SpellCheckProviderTest.MultiLineText

Review-Url: https://codereview.chromium.org/2712833004
Cr-Commit-Position: refs/heads/master@{#452899}
Committed: https://chromium.googlesource.com/chromium/src/+/0fcdf64bf2b57cfc3c21965bd037d198f7fabd4e

[Xiaocheng, 2017-02-24 01:38:23]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 01:38:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2017-02-24 01:51:04]

Description was changed from

==========
Stop SpellCheckProvider from deciding typing progress

BUG=635504
==========

to

==========
Stop SpellCheckProvider from deciding typing progress

In order not to check spelling in the middle of typing a word,
SpellCheckProvider used to decide the typing process, which is
a job that it can't reliably accomplish due to lack of information.

Now that the Blink-side SpellChecker class is no longer sending
spell check requests in the middle of typing a word, there is no
need for SpellCheckProvider to perform the check. Hence, this patch
removes the related code from SpellCheckProvider, and modifies
tests accordingly.

BUG=635504
TEST=SpellCheckProviderTest.MultiLineText
==========

[Xiaocheng, 2017-02-24 01:51:30]

xiaochengh@chromium.org changed reviewers:
+ groby@chromium.org, rouslan@chromium.org

[Xiaocheng, 2017-02-24 01:51:30]

PTAL.

[groby-ooo-7-16, 2017-02-24 02:05:52]

LGTM with a small nit - please leave a comment indicating that we'll only be
called at the end of a word, not in the middle of typing.

[commit-bot: I haz the power, 2017-02-24 03:05:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 03:05:23]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2017-02-24 14:43:41]

lgtm

[Xiaocheng, 2017-02-24 18:24:40]

The CQ bit was checked by xiaochengh@chromium.org

[Xiaocheng, 2017-02-24 18:24:40]

Thanks for the review!

Committing with a comment about partial word added.

[Xiaocheng, 2017-02-24 18:24:40]

The patchset sent to the CQ was uploaded after l-g-t-m from groby@chromium.org,
rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2712833004/#ps20001
(title: "Add comment about partial word")

[commit-bot: I haz the power, 2017-02-24 18:25:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 19:18:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487960680127460,
"parent_rev": "f8de71db706d577e6f8e0407679277022af6c8d2", "commit_rev":
"0fcdf64bf2b57cfc3c21965bd037d198f7fabd4e"}

[commit-bot: I haz the power, 2017-02-24 19:19:07]

Description was changed from

==========
Stop SpellCheckProvider from deciding typing progress

In order not to check spelling in the middle of typing a word,
SpellCheckProvider used to decide the typing process, which is
a job that it can't reliably accomplish due to lack of information.

Now that the Blink-side SpellChecker class is no longer sending
spell check requests in the middle of typing a word, there is no
need for SpellCheckProvider to perform the check. Hence, this patch
removes the related code from SpellCheckProvider, and modifies
tests accordingly.

BUG=635504
TEST=SpellCheckProviderTest.MultiLineText
==========

to

==========
Stop SpellCheckProvider from deciding typing progress

In order not to check spelling in the middle of typing a word,
SpellCheckProvider used to decide the typing process, which is
a job that it can't reliably accomplish due to lack of information.

Now that the Blink-side SpellChecker class is no longer sending
spell check requests in the middle of typing a word, there is no
need for SpellCheckProvider to perform the check. Hence, this patch
removes the related code from SpellCheckProvider, and modifies
tests accordingly.

BUG=635504
TEST=SpellCheckProviderTest.MultiLineText

Review-Url: https://codereview.chromium.org/2712833004
Cr-Commit-Position: refs/heads/master@{#452899}
Committed:
https://chromium.googlesource.com/chromium/src/+/0fcdf64bf2b57cfc3c21965bd037...
==========

[commit-bot: I haz the power, 2017-02-24 19:19:08]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/0fcdf64bf2b57cfc3c21965bd037...