Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2712773003: Fix precedence of relative position in vertical modes. (Closed)

Created:
3 years, 10 months ago by atotic
Modified:
3 years, 10 months ago
Reviewers:
kojii, eae
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix precedence of relative position in vertical modes. Original code did not take writing mode into account. BUG=695270 Review-Url: https://codereview.chromium.org/2712773003 Cr-Commit-Position: refs/heads/master@{#452758} Committed: https://chromium.googlesource.com/chromium/src/+/0f97b71bdc98d3c785b329c21134f3925f51ff3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -26 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBoxModelObject.cpp View 2 chunks +68 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
atotic
3 years, 10 months ago (2017-02-23 01:12:38 UTC) #3
kojii
Looks great, thank you for working on this. Great you found the spec, I wasn't ...
3 years, 10 months ago (2017-02-23 05:52:44 UTC) #4
kojii
I mean lgtm, but I'm not an owner, eae@?
3 years, 10 months ago (2017-02-24 02:20:38 UTC) #7
eae
RS LGTM
3 years, 10 months ago (2017-02-24 03:11:40 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712773003/1
3 years, 10 months ago (2017-02-24 03:44:41 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 05:20:45 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0f97b71bdc98d3c785b329c21134...

Powered by Google App Engine
This is Rietveld 408576698