Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2712743007: Use 'delegating constructor' in WindowManagerWindowTreeFactory (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 months ago by tonikitoo
Modified:
7 months ago
Reviewers:
sky
CC:
chromium-reviews, rjkroege
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use 'delegating constructor' in WindowManagerWindowTreeFactory The parameters of both ctors are handled the same, except for one parameter. BUG=None R=sky@chromium.org Review-Url: https://codereview.chromium.org/2712743007 Cr-Commit-Position: refs/heads/master@{#452881} Committed: https://chromium.googlesource.com/chromium/src/+/25b6521ad2777278de6d1bf5cccf861e36b255d7

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
tonikitoo
Quick driven-by CL. PTAL.
7 months ago (2017-02-24 16:38:44 UTC) #1
fwang
informal l g t m
7 months ago (2017-02-24 16:50:48 UTC) #5
sky
LGTM
7 months ago (2017-02-24 18:37:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712743007/1
7 months ago (2017-02-24 18:39:11 UTC) #10
commit-bot: I haz the power
7 months ago (2017-02-24 18:45:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/25b6521ad2777278de6d1bf5cccf...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b