Remove non-MD code from VirtualKeyboardTray

Remove non-MD code from VirtualKeyboardTray

BUG=687812
TEST=none

Review-Url: https://codereview.chromium.org/2712733003
Cr-Commit-Position: refs/heads/master@{#452315}
Committed: https://chromium.googlesource.com/chromium/src/+/6c555b4db7b5e0b3cf8277575a90f47934acd465

[mohsen, 2017-02-22 20:04:28]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 20:05:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2017-02-22 20:06:25]

mohsen@chromium.org changed reviewers:
+ tdanderson@chromium.org

[mohsen, 2017-02-22 20:06:26]

Please take a look...

[mohsen, 2017-02-22 20:47:43]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 20:48:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 21:37:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 21:37:12]

Dry run: This issue passed the CQ dry run.

[tdanderson, 2017-02-22 21:52:54]

LGTM with some comments

https://codereview.chromium.org/2712733003/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
(right):

https://codereview.chromium.org/2712733003/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc:34:
icon_->SetImage(CreateVectorIcon(kShelfKeyboardIcon, kShelfIconColor));
nit: gfx::CreateVectorIcon

https://codereview.chromium.org/2712733003/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc:103: void
VirtualKeyboardTray::SetIconBorderForShelfAlignment() {
With this patch and your other patch
https://chromiumcodereview.appspot.com/2711663003/, both implementations of
SetIconBorderForShelfAlignment() will be identical. In a follow-up CL mind
taking a look to see if there is a way this code can be shared? I also suspect
that the palette button and notification button have identical code somewhere
too since those buttons are also square in MD.

Alternatively, just add a comment on crbug.com/690992 and that can be addressed
later.

https://codereview.chromium.org/2712733003/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc:105: const
int size = GetTrayConstant(VIRTUAL_KEYBOARD_BUTTON_SIZE);
You can rip out VIRTUAL_KEYBOARD_BUTTON_SIZE entirely and just use kTrayItemSize
here (as is done in OverviewButtonTray::SetIconBorderForShelfAlignment()).

[mohsen, 2017-02-22 23:34:23]

The CQ bit was checked by mohsen@chromium.org

[mohsen, 2017-02-22 23:34:24]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdanderson@chromium.org
Link to the patchset: https://codereview.chromium.org/2712733003/#ps40001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2017-02-22 23:35:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 00:51:45]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487806463902440,
"parent_rev": "c22271f68bb5762e45c8132efa379234bd4bd3c2", "commit_rev":
"6c555b4db7b5e0b3cf8277575a90f47934acd465"}

[commit-bot: I haz the power, 2017-02-23 00:52:31]

Description was changed from

==========
Remove non-MD code from VirtualKeyboardTray

BUG=687812
TEST=none
==========

to

==========
Remove non-MD code from VirtualKeyboardTray

BUG=687812
TEST=none

Review-Url: https://codereview.chromium.org/2712733003
Cr-Commit-Position: refs/heads/master@{#452315}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c555b4db7b5e0b3cf8277575a90...
==========

[commit-bot: I haz the power, 2017-02-23 00:52:32]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6c555b4db7b5e0b3cf8277575a90...

[mohsen, 2017-02-23 04:58:32]

Forgot to publish my comments!

https://codereview.chromium.org/2712733003/diff/20001/ash/common/system/chrom...
File ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc
(right):

https://codereview.chromium.org/2712733003/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc:34:
icon_->SetImage(CreateVectorIcon(kShelfKeyboardIcon, kShelfIconColor));
On 2017/02/22 at 21:52:54, tdanderson wrote:
> nit: gfx::CreateVectorIcon

Done.

https://codereview.chromium.org/2712733003/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc:103: void
VirtualKeyboardTray::SetIconBorderForShelfAlignment() {
On 2017/02/22 at 21:52:54, tdanderson wrote:
> With this patch and your other patch
https://chromiumcodereview.appspot.com/2711663003/, both implementations of
SetIconBorderForShelfAlignment() will be identical. In a follow-up CL mind
taking a look to see if there is a way this code can be shared? I also suspect
that the palette button and notification button have identical code somewhere
too since those buttons are also square in MD.
> 
> Alternatively, just add a comment on crbug.com/690992 and that can be
addressed later.

Added comment to https://crbug.com/690992.

https://codereview.chromium.org/2712733003/diff/20001/ash/common/system/chrom...
ash/common/system/chromeos/virtual_keyboard/virtual_keyboard_tray.cc:105: const
int size = GetTrayConstant(VIRTUAL_KEYBOARD_BUTTON_SIZE);
On 2017/02/22 at 21:52:54, tdanderson wrote:
> You can rip out VIRTUAL_KEYBOARD_BUTTON_SIZE entirely and just use
kTrayItemSize here (as is done in
OverviewButtonTray::SetIconBorderForShelfAlignment()).

Done.