ValueDeserializer: Make sure that an exception is the legacy path.

ValueDeserializer: Make sure that an exception is the legacy path.

The entry points to the deserializer are responsible for ensuring that an
exception is pending by the time they return. Some failures throw exceptions
themselves, while others (like errors in the format) are exceptions caused by
the deserializer, not coming from the runtime.

Like the non-legacy path, a default deserialization exception should be thrown
in such cases.

BUG=chromium:693411
Review-Url: https://codereview.chromium.org/2712713002
Cr-Commit-Position: refs/heads/master@{#43390}
Committed: https://chromium.googlesource.com/v8/v8/+/68960eeb763f93dcedb37d5b663b1019192b7f36

[jbroman, 2017-02-22 16:45:14]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 16:45:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 17:09:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 17:09:17]

Dry run: This issue passed the CQ dry run.

[jbroman, 2017-02-22 17:39:06]

jbroman@chromium.org changed reviewers:
+ jkummerow@chromium.org

[jbroman, 2017-02-22 17:39:06]

The main path already did this sort of check, but it was missing from the legacy
path and the fuzzer spotted it.

[Jakob Kummerow, 2017-02-23 11:26:30]

lgtm

[jbroman, 2017-02-23 13:21:39]

The CQ bit was checked by jbroman@chromium.org

[commit-bot: I haz the power, 2017-02-23 13:21:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 13:23:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487856099177410, "parent_rev":
"2a2fc6922161d213a75daf39b961a43120d25063", "commit_rev":
"68960eeb763f93dcedb37d5b663b1019192b7f36"}

[commit-bot: I haz the power, 2017-02-23 13:23:05]

Description was changed from

==========
ValueDeserializer: Make sure that an exception is the legacy path.

The entry points to the deserializer are responsible for ensuring that an
exception is pending by the time they return. Some failures throw exceptions
themselves, while others (like errors in the format) are exceptions caused by
the deserializer, not coming from the runtime.

Like the non-legacy path, a default deserialization exception should be thrown
in such cases.

BUG=chromium:693411
==========

to

==========
ValueDeserializer: Make sure that an exception is the legacy path.

The entry points to the deserializer are responsible for ensuring that an
exception is pending by the time they return. Some failures throw exceptions
themselves, while others (like errors in the format) are exceptions caused by
the deserializer, not coming from the runtime.

Like the non-legacy path, a default deserialization exception should be thrown
in such cases.

BUG=chromium:693411

Review-Url: https://codereview.chromium.org/2712713002
Cr-Commit-Position: refs/heads/master@{#43390}
Committed:
https://chromium.googlesource.com/v8/v8/+/68960eeb763f93dcedb37d5b663b1019192...
==========

[commit-bot: I haz the power, 2017-02-23 13:23:06]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/68960eeb763f93dcedb37d5b663b1019192...