[css-align] Use the layout parent style to determine the value of alignment-related properties.

[css-align] Use the layout parent style to determine the value of alignment-related properties.

The css-flexbox spec defined align-self in terms of the parent element, which
is what this code did.

The css-align defines these properties in terms of the style of the containing
box instead, which means display: contents styles should not be used for this
adjustment, but the layout parent style instead.

For example, align-items is defined as:

> This property specifies the default align-self for all of the boxes
> (including anonymous boxes) participating in this box’s formatting context.

Note that the css-align spec was recently updated to align (no pun intended)
with Gecko, and make the |auto| value compute to itself.

This CL puts us in a more recent spec than before, but not totally up-to-date.

BUG=657748
Review-Url: https://codereview.chromium.org/2712673002
Cr-Commit-Position: refs/heads/master@{#453127}
Committed: https://chromium.googlesource.com/chromium/src/+/6fbdb9993cb2aa58c89e37efba312ad00d8e16ca

[emilio, 2017-02-22 12:19:33]

The CQ bit was checked by ecobos@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 12:19:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 13:32:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 13:32:05]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[emilio, 2017-02-26 19:57:39]

The CQ bit was checked by ecobos@igalia.com to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 19:57:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[emilio, 2017-02-26 19:59:13]

Description was changed from

==========
[css-align] Use the layout parent style to determine the value of
alignment-related properties.

The css-flexbox spec defined align-self in terms of the parent element, which is
what this code did.

The css-align defines these properties in terms of the style of the containing
box instead, which means display: contents styles should not be used for this
adjustment, but the layout parent style instead.

For example, align-items is defined as:

> This property specifies the default align-self for all of the boxes (including
> anonymous boxes) participating in this box’s formatting context.

BUG=657748
==========

to

==========
[css-align] Use the layout parent style to determine the value of
alignment-related properties.

The css-flexbox spec defined align-self in terms of the parent element, which
is what this code did.

The css-align defines these properties in terms of the style of the containing
box instead, which means display: contents styles should not be used for this
adjustment, but the layout parent style instead.

For example, align-items is defined as:

> This property specifies the default align-self for all of the boxes
> (including anonymous boxes) participating in this box’s formatting context.

Note that the css-align spec was recently updated to align (no pun intended)
with Gecko, and make the |auto| value compute to itself.

This CL puts us in a more recent spec than before, but not totally up-to-date.

BUG=657748
==========

[emilio, 2017-02-26 20:00:29]

ecobos@igalia.com changed reviewers:
+ rune@opera.com

[emilio, 2017-02-26 20:00:30]

rune, you might also want to review this one?

Sorry for throwing reviews at you right when you're back, feel free to redirect
or w/e if your review queue is big already.

[commit-bot: I haz the power, 2017-02-26 21:49:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 21:49:07]

Dry run: This issue passed the CQ dry run.

[rune, 2017-02-26 21:59:45]

lgtm

I what way is it not totally up-to-date? Please update the description to
clarify that.

[emilio, 2017-02-26 22:10:10]

On 2017/02/26 21:59:45, rune wrote:
> lgtm
> 
> I what way is it not totally up-to-date? Please update the description to
> clarify that.

It's explained in the description, the computed value of align-self: auto was
updated to be |auto| a few days ago, but that change is still being discussed at
https://github.com/w3c/csswg-drafts/issues/440.

[emilio, 2017-02-26 22:10:24]

The CQ bit was checked by ecobos@igalia.com

[commit-bot: I haz the power, 2017-02-26 22:10:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-26 22:15:04]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488147024389700,
"parent_rev": "701a80fd4292f4a4a9ca1899e47e274538078413", "commit_rev":
"6fbdb9993cb2aa58c89e37efba312ad00d8e16ca"}

[commit-bot: I haz the power, 2017-02-26 22:15:36]

Description was changed from

==========
[css-align] Use the layout parent style to determine the value of
alignment-related properties.

The css-flexbox spec defined align-self in terms of the parent element, which
is what this code did.

The css-align defines these properties in terms of the style of the containing
box instead, which means display: contents styles should not be used for this
adjustment, but the layout parent style instead.

For example, align-items is defined as:

> This property specifies the default align-self for all of the boxes
> (including anonymous boxes) participating in this box’s formatting context.

Note that the css-align spec was recently updated to align (no pun intended)
with Gecko, and make the |auto| value compute to itself.

This CL puts us in a more recent spec than before, but not totally up-to-date.

BUG=657748
==========

to

==========
[css-align] Use the layout parent style to determine the value of
alignment-related properties.

The css-flexbox spec defined align-self in terms of the parent element, which
is what this code did.

The css-align defines these properties in terms of the style of the containing
box instead, which means display: contents styles should not be used for this
adjustment, but the layout parent style instead.

For example, align-items is defined as:

> This property specifies the default align-self for all of the boxes
> (including anonymous boxes) participating in this box’s formatting context.

Note that the css-align spec was recently updated to align (no pun intended)
with Gecko, and make the |auto| value compute to itself.

This CL puts us in a more recent spec than before, but not totally up-to-date.

BUG=657748

Review-Url: https://codereview.chromium.org/2712673002
Cr-Commit-Position: refs/heads/master@{#453127}
Committed:
https://chromium.googlesource.com/chromium/src/+/6fbdb9993cb2aa58c89e37efba31...
==========

[commit-bot: I haz the power, 2017-02-26 22:15:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6fbdb9993cb2aa58c89e37efba31...