Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1165)

Issue 2712653002: ChromeOS OOBE: Add new image to Welcome dialog. (Closed)

Created:
3 years, 10 months ago by Alexander Alekseev
Modified:
3 years, 10 months ago
Reviewers:
achuithb
CC:
chromium-reviews, alemate+watch_chromium.org, achuith+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ChromeOS OOBE: Add new image to Welcome dialog. This Cl replaces Welcome dialog image with a new one. BUG=690725 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2712653002 Cr-Commit-Position: refs/heads/master@{#452354} Committed: https://chromium.googlesource.com/chromium/src/+/65217792e655c9fa998f00b56b952192452b357c

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
A chrome/browser/resources/chromeos/login/images/welcome_illustration_1x.png View Binary file 0 comments Download
M chrome/browser/resources/chromeos/login/images/welcome_illustration_2x.png View Binary file 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome_dialog.css View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_welcome_dialog.html View 1 chunk +3 lines, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
Alexander Alekseev
Please review.
3 years, 10 months ago (2017-02-22 10:32:22 UTC) #3
Alexander Alekseev
On 2017/02/22 10:32:22, Alexander Alekseev wrote: > Please review. Please also note that it depends ...
3 years, 10 months ago (2017-02-22 10:36:23 UTC) #6
achuithb
lgtm
3 years, 10 months ago (2017-02-22 10:52:08 UTC) #7
commit-bot: I haz the power
This CL has an open dependency (Issue 2710933002 Patch 40001). Please resolve the dependency and ...
3 years, 10 months ago (2017-02-22 23:42:27 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712653002/20001
3 years, 10 months ago (2017-02-23 00:54:31 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 02:39:40 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/65217792e655c9fa998f00b56b95...

Powered by Google App Engine
This is Rietveld 408576698