Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2712643007: Added test case for crbug.com/694865 regression. (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added test cases for crbug.com/694865 regression. IFrameWithInvalidURL loads <iframe src='http://%3'/> page and expects that about:blank navigation will not happen. LoadInvalidURL loads a page with invalid URL and expects that about:blank is loaded instead. BUG=694865 Review-Url: https://codereview.chromium.org/2712643007 Cr-Commit-Position: refs/heads/master@{#452903} Committed: https://chromium.googlesource.com/chromium/src/+/79b6f0b6ef5566a8be1b4650004142b53f862023

Patch Set 1 #

Patch Set 2 : Test case for loading invalid URL #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -0 lines) Patch
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 2 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-02-24 16:56:50 UTC) #7
kkhorimoto
lgtm
3 years, 10 months ago (2017-02-24 19:02:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712643007/20001
3 years, 10 months ago (2017-02-24 19:09:55 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 19:34:51 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/79b6f0b6ef5566a8be1b46500041...

Powered by Google App Engine
This is Rietveld 408576698