Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 2712643004: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (Cloud Print related). Thanks. Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: List of components https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2712643004 Cr-Commit-Position: refs/heads/master@{#452878} Committed: https://chromium.googlesource.com/chromium/src/+/fd502a80c0f1aabd7c18d74b8c15c8e93dddff59

Patch Set 1 #

Total comments: 12

Patch Set 2 : update component #

Total comments: 4

Patch Set 3 : update component #

Total comments: 3

Patch Set 4 : add owner #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M chrome/browser/local_discovery/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/printing/cloud_print/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/cloud_print_app/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/local_discovery/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/print_preview/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/service_process/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/local_discovery/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/cloud_print/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/service/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/tools/service_discovery_sniffer/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/utility/cloud_print/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/cloud_devices/OWNERS View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M printing/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 40 (18 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-22 21:25:34 UTC) #3
gene1
LGTM However, neither me nor Vitaly or Scott work on Chrome anymore. We all moved ...
3 years, 10 months ago (2017-02-22 22:20:28 UTC) #4
ymzhang1
Thanks for the information! Maybe figuring out team mailing list for these components could help. ...
3 years, 10 months ago (2017-02-22 23:40:55 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712643004/1
3 years, 10 months ago (2017-02-22 23:41:39 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 10 months ago (2017-02-22 23:41:40 UTC) #10
ymzhang1
Hi gene@ Sorry to bother again. Would you mind lgtm with your chromium account if ...
3 years, 10 months ago (2017-02-22 23:47:29 UTC) #11
sshruthi1
On 2017/02/22 23:40:55, ymzhang1 wrote: > Thanks for the information! > > Maybe figuring out ...
3 years, 10 months ago (2017-02-22 23:48:14 UTC) #14
Lei Zhang
I'm very very behind on email. Care to shoot me a separate email about team ...
3 years, 10 months ago (2017-02-23 01:15:01 UTC) #17
ymzhang1
Sure. I will send you(thestig@) a separate email about team mailing lists. Additional note about ...
3 years, 10 months ago (2017-02-23 22:41:43 UTC) #19
Lei Zhang
https://codereview.chromium.org/2712643004/diff/20001/chrome/browser/ui/webui/local_discovery/OWNERS File chrome/browser/ui/webui/local_discovery/OWNERS (right): https://codereview.chromium.org/2712643004/diff/20001/chrome/browser/ui/webui/local_discovery/OWNERS#newcode4 chrome/browser/ui/webui/local_discovery/OWNERS:4: # COMPONENT: UI>Browser>WebUI If you can only have 1 ...
3 years, 10 months ago (2017-02-23 22:45:27 UTC) #20
Lei Zhang
On 2017/02/23 22:41:43, ymzhang1 wrote: > Sure. I will send you(thestig@) a separate email about ...
3 years, 10 months ago (2017-02-23 22:46:52 UTC) #21
ymzhang1
https://codereview.chromium.org/2712643004/diff/20001/chrome/browser/ui/webui/local_discovery/OWNERS File chrome/browser/ui/webui/local_discovery/OWNERS (right): https://codereview.chromium.org/2712643004/diff/20001/chrome/browser/ui/webui/local_discovery/OWNERS#newcode4 chrome/browser/ui/webui/local_discovery/OWNERS:4: # COMPONENT: UI>Browser>WebUI On 2017/02/23 22:45:26, Lei Zhang (super ...
3 years, 10 months ago (2017-02-23 22:48:38 UTC) #22
Lei Zhang
lgtm
3 years, 10 months ago (2017-02-23 22:50:39 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712643004/40001
3 years, 10 months ago (2017-02-23 22:52:04 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/371775)
3 years, 10 months ago (2017-02-23 23:13:37 UTC) #28
Lei Zhang
+vitalybuka for a quick stamp for components/cloud_devices/OWNERS.
3 years, 10 months ago (2017-02-23 23:39:29 UTC) #30
Vitaly Buka (NO REVIEWS)
lgtm https://codereview.chromium.org/2712643004/diff/40001/components/cloud_devices/OWNERS File components/cloud_devices/OWNERS (left): https://codereview.chromium.org/2712643004/diff/40001/components/cloud_devices/OWNERS#oldcode2 components/cloud_devices/OWNERS:2: vitalybuka@chromium.org Lei, probably you should put yourself here. ...
3 years, 10 months ago (2017-02-24 00:17:09 UTC) #31
Lei Zhang
https://codereview.chromium.org/2712643004/diff/40001/components/cloud_devices/OWNERS File components/cloud_devices/OWNERS (left): https://codereview.chromium.org/2712643004/diff/40001/components/cloud_devices/OWNERS#oldcode2 components/cloud_devices/OWNERS:2: vitalybuka@chromium.org On 2017/02/24 00:17:08, Vitaly Buka wrote: > Lei, ...
3 years, 10 months ago (2017-02-24 00:18:30 UTC) #32
ymzhang1
https://codereview.chromium.org/2712643004/diff/40001/components/cloud_devices/OWNERS File components/cloud_devices/OWNERS (left): https://codereview.chromium.org/2712643004/diff/40001/components/cloud_devices/OWNERS#oldcode2 components/cloud_devices/OWNERS:2: vitalybuka@chromium.org On 2017/02/24 00:17:08, Vitaly Buka wrote: > Lei, ...
3 years, 10 months ago (2017-02-24 00:19:08 UTC) #33
Lei Zhang
On 2017/02/24 00:19:08, ymzhang1 wrote: > https://codereview.chromium.org/2712643004/diff/40001/components/cloud_devices/OWNERS > File components/cloud_devices/OWNERS (left): > > https://codereview.chromium.org/2712643004/diff/40001/components/cloud_devices/OWNERS#oldcode2 > ...
3 years, 10 months ago (2017-02-24 03:18:52 UTC) #34
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712643004/60001
3 years, 10 months ago (2017-02-24 17:57:08 UTC) #37
commit-bot: I haz the power
3 years, 10 months ago (2017-02-24 18:26:32 UTC) #40
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/fd502a80c0f1aabd7c18d74b8c15...

Powered by Google App Engine
This is Rietveld 408576698