Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2712603003: Move tests in fast/dom/Selection/ to editing/selection/. (Closed)

Created:
3 years, 10 months ago by tkent
Modified:
3 years, 10 months ago
Reviewers:
yoichio, yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move tests in fast/dom/Selection/ to editing/selection/. Also, remove the following tests because they are covered by external/wpt/selection/. - collapseToX-empty-selection.html - getRangeAt.html - selection-interface.html BUG=685886 Review-Url: https://codereview.chromium.org/2712603003 Cr-Commit-Position: refs/heads/master@{#452349} Committed: https://chromium.googlesource.com/chromium/src/+/9cd7a721e9e74feaee3600e1786ad03efe3a0ed4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -221 lines) Patch
A + third_party/WebKit/LayoutTests/editing/selection/missing-arguments.html View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/editing/selection/missing-arguments-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/editing/selection/selection-crash.html View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/editing/selection/use-counters.html View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Selection/collapseToX-empty-selection.html View 1 chunk +0 lines, -25 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Selection/collapseToX-empty-selection-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Selection/getRangeAt.html View 1 chunk +0 lines, -41 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Selection/getRangeAt-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Selection/missing-arguments.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Selection/missing-arguments-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Selection/selection-crash.html View 1 chunk +0 lines, -34 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Selection/selection-interface.html View 1 chunk +0 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/fast/dom/Selection/use-counters.html View 1 chunk +0 lines, -19 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
tkent
yoichio@, yosin@, would you stamp this please?
3 years, 10 months ago (2017-02-23 01:44:45 UTC) #4
yoichio
lgtm
3 years, 10 months ago (2017-02-23 01:52:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712603003/1
3 years, 10 months ago (2017-02-23 02:14:45 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 02:21:53 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9cd7a721e9e74feaee3600e1786a...

Powered by Google App Engine
This is Rietveld 408576698