Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2712513003:
Document how to build Chromium for devices. (Closed)
DescriptionDocument how to build Chromium for devices.
Document how to build Chromium for devices, how to configure the
Code Signing Identity to use and which Mobile Provisioning Profile
are required to build Chromium and the tests for device.
BUG=694604
Review-Url: https://codereview.chromium.org/2712513003
Cr-Commit-Position: refs/heads/master@{#452459}
Committed: https://chromium.googlesource.com/chromium/src/+/9d63b30c1e8d80834fd033636bcbbed3a21c34b0
Patch Set 1 #
Total comments: 53
Patch Set 2 : Address comments. #Patch Set 3 : Fix more Capitalized Words and add group.${prefix}.common. #Messages
Total messages: 20 (11 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
sdefresne@chromium.org changed reviewers: + lod@google.com, marq@chromium.org
Please take a look.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (right): https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:116: Please refer to Apple documentation on how to get a code signing identity ... to the Apple documentation ... https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:117: and certificates. You can check that you have a code signing correctly ... code signing identity ... https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:133: ### Mobile Provisioning Profiles The rest of the document uses sentence case for section heads, so you should follow that -- only capitalize the first word, unless the word is part of a proper noun. ("provisioning profile" isn't a proper noun.) https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:137: `ios_app_bundle_id_prefix` and usually corresponds to a reverted domain name s/reverted/reversed/ https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:141: for the following Bundle Identifiers to build and run Chromium with the ... with these application extensions: https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:148: All those certificates need to have the "App Groups" capability enabled for All these ... https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:171: profile for EarlGrey and OCHamcrest frameworks: profiles https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:176: In addition to that, the you'll need one additional Provisioning Profile for No caps on provisioning profile https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:177: the xctest module too. This module Bundle Identifier depends on whether the XCTest? https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:177: the xctest module too. This module Bundle Identifier depends on whether the No caps on bundle identifier. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:190: will fails and will print the Bundle Identifier of the bundle the could not ... will fail ... ... bundle that could not be ... https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:202: Here, the build is failing because there are no Mobile Provisioning Profile mobile provisioning profiles (no caps, plural) https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:205: request from Apple such a Mobile Provisioning Profile. ... request such a mobile provisioning profile from Apple. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:208: to check which capabilites are required for the Mobile Provisioning Profile no caps on mobile provisioning profile, here and below. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:210: remember that the path are relative to the build directory, not to the source ... the path is ... (or, if this is plural, "the paths are"). https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:214: then it will be impossible to install the application on a device (Xcode will XCode https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:215: print an error stating that "The application was signed with invalid print -> display
lod@chromium.org changed reviewers: + lod@chromium.org
https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (right): https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:117: and certificates. You can check that you have a code signing correctly a code signing identity* https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:137: `ios_app_bundle_id_prefix` and usually corresponds to a reverted domain name inverted? https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:140: You then need to request from Apple provisioning profiles for your devices swap "from Apple" "provisioning profiles" https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:171: profile for EarlGrey and OCHamcrest frameworks: profiles https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:176: In addition to that, the you'll need one additional Provisioning Profile for remove the https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:190: will fails and will print the Bundle Identifier of the bundle the could not will fail https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:190: will fails and will print the Bundle Identifier of the bundle the could not the = that? https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:210: remember that the path are relative to the build directory, not to the source the path is, paths are
olivierrobin@chromium.org changed reviewers: + olivierrobin@chromium.org
https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (right): https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:148: All those certificates need to have the "App Groups" capability enabled for s/App groups/App groups (com.apple.security.application-groups)/ https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:149: the `group.${prefix}.chrome` group. - group.${prefix}.chrome: This group is only shared between Chrome and its extensions to share files and configurations. - group.${prefix}.common: This group can be shared with other applications in the same organization and can be used to send commands to Chrome.
Thank you both for the review. Please take another look. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (right): https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:116: Please refer to Apple documentation on how to get a code signing identity On 2017/02/22 14:51:21, marq wrote: > ... to the Apple documentation ... Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:117: and certificates. You can check that you have a code signing correctly On 2017/02/22 14:51:20, marq wrote: > ... code signing identity ... Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:117: and certificates. You can check that you have a code signing correctly On 2017/02/22 14:52:31, lody wrote: > a code signing identity* Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:133: ### Mobile Provisioning Profiles On 2017/02/22 14:51:21, marq wrote: > The rest of the document uses sentence case for section heads, so you should > follow that -- only capitalize the first word, unless the word is part of a > proper noun. ("provisioning profile" isn't a proper noun.) Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:137: `ios_app_bundle_id_prefix` and usually corresponds to a reverted domain name On 2017/02/22 14:51:21, marq wrote: > s/reverted/reversed/ Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:137: `ios_app_bundle_id_prefix` and usually corresponds to a reverted domain name On 2017/02/22 14:52:30, lody wrote: > inverted? Used "reversed" as suggested by marq. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:140: You then need to request from Apple provisioning profiles for your devices On 2017/02/22 14:52:30, lody wrote: > swap "from Apple" "provisioning profiles" Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:141: for the following Bundle Identifiers to build and run Chromium with the On 2017/02/22 14:51:20, marq wrote: > ... with these application extensions: Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:148: All those certificates need to have the "App Groups" capability enabled for On 2017/02/22 14:51:21, marq wrote: > All these ... Done. What's the difference between "these" and "those"? https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:171: profile for EarlGrey and OCHamcrest frameworks: On 2017/02/22 14:51:21, marq wrote: > profiles Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:171: profile for EarlGrey and OCHamcrest frameworks: On 2017/02/22 14:52:30, lody wrote: > profiles Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:176: In addition to that, the you'll need one additional Provisioning Profile for On 2017/02/22 14:51:20, marq wrote: > No caps on provisioning profile Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:176: In addition to that, the you'll need one additional Provisioning Profile for On 2017/02/22 14:52:30, lody wrote: > remove the It was supposed to be "then". https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:177: the xctest module too. This module Bundle Identifier depends on whether the On 2017/02/22 14:51:20, marq wrote: > No caps on bundle identifier. Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:177: the xctest module too. This module Bundle Identifier depends on whether the On 2017/02/22 14:51:21, marq wrote: > XCTest? Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:190: will fails and will print the Bundle Identifier of the bundle the could not On 2017/02/22 14:51:21, marq wrote: > ... will fail ... > ... bundle that could not be ... Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:190: will fails and will print the Bundle Identifier of the bundle the could not On 2017/02/22 14:52:30, lody wrote: > will fail Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:190: will fails and will print the Bundle Identifier of the bundle the could not On 2017/02/22 14:52:30, lody wrote: > the = that? Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:202: Here, the build is failing because there are no Mobile Provisioning Profile On 2017/02/22 14:51:21, marq wrote: > mobile provisioning profiles (no caps, plural) Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:205: request from Apple such a Mobile Provisioning Profile. On 2017/02/22 14:51:20, marq wrote: > ... request such a mobile provisioning profile from Apple. Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:208: to check which capabilites are required for the Mobile Provisioning Profile On 2017/02/22 14:51:21, marq wrote: > no caps on mobile provisioning profile, here and below. Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:210: remember that the path are relative to the build directory, not to the source On 2017/02/22 14:51:21, marq wrote: > ... the path is ... (or, if this is plural, "the paths are"). Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:210: remember that the path are relative to the build directory, not to the source On 2017/02/22 14:52:30, lody wrote: > the path is, paths are Done. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:214: then it will be impossible to install the application on a device (Xcode will On 2017/02/22 14:51:21, marq wrote: > XCode Apple uses "Xcode", see for example https://developer.apple.com/xcode/. https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:215: print an error stating that "The application was signed with invalid On 2017/02/22 14:51:21, marq wrote: > print -> display Done.
lgtm
lgtm https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions.md File docs/ios_build_instructions.md (right): https://codereview.chromium.org/2712513003/diff/1/docs/ios_build_instructions... docs/ios_build_instructions.md:148: All those certificates need to have the "App Groups" capability enabled for On 2017/02/23 09:10:55, sdefresne wrote: > On 2017/02/22 14:51:21, marq wrote: > > All these ... > > Done. > > What's the difference between "these" and "those"? In this case it's somewhat subtle. In general use, 'this' and 'these' are used for things close to the speaker, and 'that' and 'those' are used for things distant from the speaker. But 'distance' can be both relative and metaphorical; for example you might use 'those' to refer to things that were finished or in the past. Here I think 'these' sounds better because it emphasizes that the reader is still doing things with the certificates in question.
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from lod@chromium.org, marq@chromium.org Link to the patchset: https://codereview.chromium.org/2712513003/#ps40001 (title: "Fix more Capitalized Words and add group.${prefix}.common.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487846868419450,
"parent_rev": "2a4d9d1f74a04c1122bc7ca32027da87cb14d3bd", "commit_rev":
"9d63b30c1e8d80834fd033636bcbbed3a21c34b0"}
Message was sent while issue was closed.
Description was changed from ========== Document how to build Chromium for devices. Document how to build Chromium for devices, how to configure the Code Signing Identity to use and which Mobile Provisioning Profile are required to build Chromium and the tests for device. BUG=694604 ========== to ========== Document how to build Chromium for devices. Document how to build Chromium for devices, how to configure the Code Signing Identity to use and which Mobile Provisioning Profile are required to build Chromium and the tests for device. BUG=694604 Review-Url: https://codereview.chromium.org/2712513003 Cr-Commit-Position: refs/heads/master@{#452459} Committed: https://chromium.googlesource.com/chromium/src/+/9d63b30c1e8d80834fd033636bcb... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/9d63b30c1e8d80834fd033636bcb... |
