Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2712433002:
Add note to ui/gfx/vector_icons/BUILD to reduce developer confusion as (Closed)
|
Created:
3 years, 10 months ago by Evan Stade Modified:
3 years, 10 months ago Reviewers:
tdanderson CC:
chromium-reviews Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdd note to ui/gfx/vector_icons/BUILD to reduce developer confusion as
we transition to different vector icon targets.
NOTRY=true
BUG=626786
Review-Url: https://codereview.chromium.org/2712433002
Cr-Commit-Position: refs/heads/master@{#452099}
Committed: https://chromium.googlesource.com/chromium/src/+/65b29245034c4f14504cac85af8b87ae0ed8e193
Patch Set 1 #
Messages
Total messages: 17 (9 generated)
estade@chromium.org changed reviewers: + tdanderson@chromium.org
LGTM
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
Description was changed from ========== Add note to ui/gfx/vector_icons/BUILD to reduce developer confusion as we transition to different vector icon targets. BUG=626786 ========== to ========== Add note to ui/gfx/vector_icons/BUILD to reduce developer confusion as we transition to different vector icon targets. NOTRY=true BUG=626786 ==========
The CQ bit was checked by estade@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1487782900096440, "parent_rev":
"681f02dc0ce55aa3381e05138fe64c43b451cf0b", "commit_rev":
"65b29245034c4f14504cac85af8b87ae0ed8e193"}
Message was sent while issue was closed.
Description was changed from ========== Add note to ui/gfx/vector_icons/BUILD to reduce developer confusion as we transition to different vector icon targets. NOTRY=true BUG=626786 ========== to ========== Add note to ui/gfx/vector_icons/BUILD to reduce developer confusion as we transition to different vector icon targets. NOTRY=true BUG=626786 Review-Url: https://codereview.chromium.org/2712433002 Cr-Commit-Position: refs/heads/master@{#452099} Committed: https://chromium.googlesource.com/chromium/src/+/65b29245034c4f14504cac85af8b... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/65b29245034c4f14504cac85af8b... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
