Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2712413002: Remove ScopedVector in //components/dom_distiller/ (Closed)

Created:
3 years, 9 months ago by ke.he
Modified:
3 years, 9 months ago
Reviewers:
mdjones, nyquist
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ScopedVector in //components/dom_distiller/ BUG=554289 Review-Url: https://codereview.chromium.org/2712413002 Cr-Commit-Position: refs/heads/master@{#454156} Committed: https://chromium.googlesource.com/chromium/src/+/9c283abb7dbff23b012539429f81aeb64dd319c8

Patch Set 1 #

Patch Set 2 : Remove ScopedVector in //components/dom_distiller/ #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -37 lines) Patch
M components/dom_distiller/core/distiller.h View 3 chunks +3 lines, -3 lines 0 comments Download
M components/dom_distiller/core/distiller.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M components/dom_distiller/core/distiller_unittest.cc View 7 chunks +8 lines, -7 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_service.h View 2 chunks +1 line, -2 lines 0 comments Download
M components/dom_distiller/core/dom_distiller_service.cc View 1 4 chunks +14 lines, -10 lines 0 comments Download
M components/dom_distiller/standalone/content_extractor_browsertest.cc View 1 4 chunks +9 lines, -7 lines 1 comment Download

Messages

Total messages: 21 (15 generated)
ke.he
Hi, Mdjones@, Could you PTAL on this, Thanks!
3 years, 9 months ago (2017-02-27 11:31:54 UTC) #11
ke.he
https://codereview.chromium.org/2712413002/diff/20001/components/dom_distiller/standalone/content_extractor_browsertest.cc File components/dom_distiller/standalone/content_extractor_browsertest.cc (right): https://codereview.chromium.org/2712413002/diff/20001/components/dom_distiller/standalone/content_extractor_browsertest.cc#newcode261 components/dom_distiller/standalone/content_extractor_browsertest.cc:261: requests.push_back(base::WrapUnique(new ContentExtractionRequest(url))); we use "base::WrapUnique" instead of "base::MakeUnique" because ...
3 years, 9 months ago (2017-03-01 02:58:27 UTC) #12
nyquist
lgtm
3 years, 9 months ago (2017-03-01 16:55:17 UTC) #15
mdjones
lgtm
3 years, 9 months ago (2017-03-01 16:55:59 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712413002/20001
3 years, 9 months ago (2017-03-02 01:11:38 UTC) #18
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 02:36:59 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9c283abb7dbff23b012539429f81...

Powered by Google App Engine
This is Rietveld 408576698