Files app: Work around the issue about opening menus by keeping references to <hr>s.

Files app: Work around the issue about opening menus by keeping references to <hr>s.

Files app's settings menu uses cr.ui.Menu, and <hr>s in the menu needs to be
decorated by cr.ui.MenuItem. However, in some cases, the <hr>s can lose the
decorated functions for some reason (suspected that it's by GC for <hr> wrappers).
This behavior be worked around by explicitly keeping reference to those <hr>s.

BUG=689255
TEST=confirmed 300+ trials of repro step did not reproduce the issue. It reproduced around 10% without the patch.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2712403003
Cr-Commit-Position: refs/heads/master@{#453557}
Committed: https://chromium.googlesource.com/chromium/src/+/3bc177a7e5b7d15e6635613373ac316263576150

[fukino, 2017-02-27 10:13:16]

Description was changed from

==========
Files app: Work around the issue about opening menus by keeping references to
<hr>s.

Files app's settings menu uses cr.ui.Menu, and <hr>s in the menu needs to be
decorated by cr.ui.MenuItem. However, in some cases, the <hr>s can lose the
decorated functions for some reason (suspected that it's by GC for <hr>
wrappers).
This behavior be worked around by explicitly keeping reference to those <hr>s.

BUG=689255
TEST=confirmed 300+ trials of repro step did not reproduce the issue. It
reproduced around 10% without the patch.
==========

to

==========
Files app: Work around the issue about opening menus by keeping references to
<hr>s.

Files app's settings menu uses cr.ui.Menu, and <hr>s in the menu needs to be
decorated by cr.ui.MenuItem. However, in some cases, the <hr>s can lose the
decorated functions for some reason (suspected that it's by GC for <hr>
wrappers).
This behavior be worked around by explicitly keeping reference to those <hr>s.

BUG=689255
TEST=confirmed 300+ trials of repro step did not reproduce the issue. It
reproduced around 10% without the patch.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[fukino, 2017-02-27 10:13:44]

fukino@chromium.org changed reviewers:
+ oka@chromium.org

[fukino, 2017-02-27 10:58:20]

The CQ bit was checked by fukino@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 10:58:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 11:22:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 11:22:14]

Dry run: This issue passed the CQ dry run.

[oka, 2017-02-28 02:04:06]

lgtm

https://codereview.chromium.org/2712403003/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js (right):

https://codereview.chromium.org/2712403003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js:41: *
TODO(fukino): Remove this membar variable once the root cause is fixed.
s/membar/member/

[fukino, 2017-02-28 09:09:27]

Thanks!

https://codereview.chromium.org/2712403003/diff/1/ui/file_manager/file_manage...
File ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js (right):

https://codereview.chromium.org/2712403003/diff/1/ui/file_manager/file_manage...
ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js:41: *
TODO(fukino): Remove this membar variable once the root cause is fixed.
On 2017/02/28 02:04:06, oka wrote:
> s/membar/member/

Done.

[fukino, 2017-02-28 09:09:31]

The CQ bit was checked by fukino@chromium.org

[fukino, 2017-02-28 09:09:31]

The patchset sent to the CQ was uploaded after l-g-t-m from oka@chromium.org
Link to the patchset: https://codereview.chromium.org/2712403003/#ps20001
(title: "Fix a typo.")

[commit-bot: I haz the power, 2017-02-28 09:09:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 09:54:40]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488272971662610,
"parent_rev": "525fa6787336cb9d251ca2c264755bc0625f9b74", "commit_rev":
"3bc177a7e5b7d15e6635613373ac316263576150"}

[commit-bot: I haz the power, 2017-02-28 09:55:14]

Description was changed from

==========
Files app: Work around the issue about opening menus by keeping references to
<hr>s.

Files app's settings menu uses cr.ui.Menu, and <hr>s in the menu needs to be
decorated by cr.ui.MenuItem. However, in some cases, the <hr>s can lose the
decorated functions for some reason (suspected that it's by GC for <hr>
wrappers).
This behavior be worked around by explicitly keeping reference to those <hr>s.

BUG=689255
TEST=confirmed 300+ trials of repro step did not reproduce the issue. It
reproduced around 10% without the patch.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Files app: Work around the issue about opening menus by keeping references to
<hr>s.

Files app's settings menu uses cr.ui.Menu, and <hr>s in the menu needs to be
decorated by cr.ui.MenuItem. However, in some cases, the <hr>s can lose the
decorated functions for some reason (suspected that it's by GC for <hr>
wrappers).
This behavior be worked around by explicitly keeping reference to those <hr>s.

BUG=689255
TEST=confirmed 300+ trials of repro step did not reproduce the issue. It
reproduced around 10% without the patch.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2712403003
Cr-Commit-Position: refs/heads/master@{#453557}
Committed:
https://chromium.googlesource.com/chromium/src/+/3bc177a7e5b7d15e6635613373ac...
==========

[commit-bot: I haz the power, 2017-02-28 09:55:15]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/3bc177a7e5b7d15e6635613373ac...