Issue 2712373002: [Fix m57 branch merge from] Anchor the first run bubble off the location bar icon's ImageView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2712373002: [Fix m57 branch merge from] Anchor the first run bubble off the location bar icon's ImageView. (Closed)

Created:
3 years, 9 months ago by tapted

Modified:
3 years, 9 months ago

Reviewers:

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2987

Project:
chromium

Visibility:
Public.

[Fix m57 branch merge from] Anchor the first run bubble off the location bar icon's ImageView. Compile fails with 'GetSecurityBubbleAnchorView': identifier not found. Use GetImageView() instead. BUG=696379, 690361 Review-Url: https://codereview.chromium.org/2705323004 Cr-Commit-Position: refs/heads/master@{#452728} (cherry picked from commit 96752f23762f0ad4320bb4aa0737857b5fe582f3) Review-Url: https://codereview.chromium.org/2712373002 . Cr-Commit-Position: refs/branch-heads/2987@{#692} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/fb276cc794bf3fb3e7273e4ef2aab7c12622ef36

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/ui/views/location_bar/location_bar_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (1 generated)

tapted

3 years, 9 months ago (2017-02-27 03:03:32 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
fb276cc794bf3fb3e7273e4ef2aab7c12622ef36.