Remove non-MD code from ShelfButton

Remove non-MD code from ShelfButton

BUG=687805
TEST=none

Review-Url: https://codereview.chromium.org/2712293002
Cr-Commit-Position: refs/heads/master@{#453713}
Committed: https://chromium.googlesource.com/chromium/src/+/e883e24ee401658ae1537634f497a5a2bec5592f

[mohsen, 2017-02-26 16:30:31]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 16:30:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-26 16:32:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 16:32:59]

Dry run: Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)

[mohsen, 2017-02-26 16:56:04]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-26 16:56:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-26 17:28:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-26 17:28:21]

Dry run: This issue passed the CQ dry run.

[mohsen, 2017-02-28 18:40:57]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 18:41:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2017-02-28 18:55:54]

mohsen@chromium.org changed reviewers:
+ jamescook@chromium.org

[mohsen, 2017-02-28 18:55:54]

Please take a look...

[commit-bot: I haz the power, 2017-02-28 19:15:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 19:15:44]

Dry run: This issue passed the CQ dry run.

[James Cook, 2017-02-28 20:35:11]

LGTM with nit

Thanks for remembering to clean up the asset files -- historically people
sometimes forget. :-)

https://codereview.chromium.org/2712293002/diff/40001/ash/test/shelf_view_tes...
File ash/test/shelf_view_test_api.cc (right):

https://codereview.chromium.org/2712293002/diff/40001/ash/test/shelf_view_tes...
ash/test/shelf_view_test_api.cc:138: int ShelfViewTestAPI::GetButtonSize() {
nit: Since this and GetButtonSpacing() just return constants, can you remove
these methods entirely and inline the constants in the tests that use them?

[mohsen, 2017-02-28 21:03:12]

The CQ bit was checked by mohsen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-28 21:05:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mohsen, 2017-02-28 21:05:16]

https://codereview.chromium.org/2712293002/diff/40001/ash/test/shelf_view_tes...
File ash/test/shelf_view_test_api.cc (right):

https://codereview.chromium.org/2712293002/diff/40001/ash/test/shelf_view_tes...
ash/test/shelf_view_test_api.cc:138: int ShelfViewTestAPI::GetButtonSize() {
On 2017/02/28 at 20:35:11, James Cook wrote:
> nit: Since this and GetButtonSpacing() just return constants, can you remove
these methods entirely and inline the constants in the tests that use them?

Sure, I didn't remove these methods because GetMinimumDragDistance() is also
returning a constant and I wanted to be consistent. However, that one is
returning a private constant, so it makes sense to have an accessor in test api.
These ones are public constants. Done.

[commit-bot: I haz the power, 2017-02-28 21:09:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-28 21:09:23]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mohsen, 2017-02-28 21:11:40]

The CQ bit was checked by mohsen@chromium.org

[mohsen, 2017-02-28 21:11:41]

The patchset sent to the CQ was uploaded after l-g-t-m from
jamescook@chromium.org
Link to the patchset: https://codereview.chromium.org/2712293002/#ps80001
(title: "Rebased")

[commit-bot: I haz the power, 2017-02-28 21:12:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 21:55:01]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488316300662940,
"parent_rev": "f1d756b8310d09fcd4a3e7ab751c4e184c84d5b5", "commit_rev":
"e883e24ee401658ae1537634f497a5a2bec5592f"}

[commit-bot: I haz the power, 2017-02-28 21:55:59]

Description was changed from

==========
Remove non-MD code from ShelfButton

BUG=687805
TEST=none
==========

to

==========
Remove non-MD code from ShelfButton

BUG=687805
TEST=none

Review-Url: https://codereview.chromium.org/2712293002
Cr-Commit-Position: refs/heads/master@{#453713}
Committed:
https://chromium.googlesource.com/chromium/src/+/e883e24ee401658ae1537634f497...
==========

[commit-bot: I haz the power, 2017-02-28 21:56:00]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/e883e24ee401658ae1537634f497...