Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Issue 2712243002: Make Editor::respondToChangedContents take a Position (Closed)

Created:
3 years, 10 months ago by Xiaocheng
Modified:
3 years, 9 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make Editor::respondToChangedContents take a Position This patch makes the above mentioned function take a Position as its parameter instead of a VisibleSelection. This is also a preparation of removing layout update from Editor::applied/unapplied/reappliedEditing. BUG=657237 TEST=n/a; no behavior change Review-Url: https://codereview.chromium.org/2712243002 Cr-Commit-Position: refs/heads/master@{#453158} Committed: https://chromium.googlesource.com/chromium/src/+/d57cc7528932df35ce4a7d56f7cfc9dc380e5a09

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/editing/Editor.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Editor.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Xiaocheng
PTAL. Last patch for today...
3 years, 10 months ago (2017-02-25 02:43:04 UTC) #4
yosin_UTC9
lgtm Good catch!
3 years, 9 months ago (2017-02-27 01:25:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712243002/1
3 years, 9 months ago (2017-02-27 03:23:11 UTC) #9
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 05:23:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d57cc7528932df35ce4a7d56f7cf...

Powered by Google App Engine
This is Rietveld 408576698