Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Issue 2712213002: Remove notification and message for security-only state (Closed)

Created:
3 years, 10 months ago by xiaoyinh(OOO Sep 11-29)
Modified:
3 years, 9 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove notification and message for security-only state BUG=694853 Review-Url: https://codereview.chromium.org/2712213002 Cr-Commit-Position: refs/heads/master@{#453384} Committed: https://chromium.googlesource.com/chromium/src/+/f4e5b5bce2407d2bbe3f09fa0781162dfe6b6bc8

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -37 lines) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +2 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/eol_notification.cc View 4 chunks +6 lines, -15 lines 0 comments Download
M chrome/browser/ui/webui/help/help_handler.cc View 3 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
xiaoyinh(OOO Sep 11-29)
Please take a look, thanks!
3 years, 10 months ago (2017-02-24 22:56:39 UTC) #4
xiyuan
https://codereview.chromium.org/2712213002/diff/1/chrome/browser/ui/webui/help/help_handler.cc File chrome/browser/ui/webui/help/help_handler.cc (right): https://codereview.chromium.org/2712213002/diff/1/chrome/browser/ui/webui/help/help_handler.cc#newcode747 chrome/browser/ui/webui/help/help_handler.cc:747: if (status == update_engine::EndOfLifeStatus::kSecurityOnly || Just to confirm: - ...
3 years, 9 months ago (2017-02-27 18:02:33 UTC) #7
xiyuan
lgtm per offline discussion.
3 years, 9 months ago (2017-02-27 18:37:39 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712213002/20001
3 years, 9 months ago (2017-02-27 21:51:23 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 23:23:28 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f4e5b5bce2407d2bbe3f09fa0781...

Powered by Google App Engine
This is Rietveld 408576698