Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(595)

Issue 2712193002: PPC: Declare XX3 format assembler function with opcode list macro (Closed)

Created:
3 years, 10 months ago by Sampson
Modified:
3 years, 9 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Declare XX3 format assembler function with opcode list macro BUG= R=bjaideep@ca.ibm.com, jyan@ca.ibm.com, joransiu@ca.ibm.com Review-Url: https://codereview.chromium.org/2712193002 Cr-Commit-Position: refs/heads/master@{#43456} Committed: https://chromium.googlesource.com/v8/v8/+/7d1d83e52561e287c334143a9d110916dfc5998e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -41 lines) Patch
M src/ppc/assembler-ppc.h View 3 chunks +19 lines, -13 lines 0 comments Download
M src/ppc/assembler-ppc.cc View 2 chunks +0 lines, -28 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Sampson
Please take a look
3 years, 10 months ago (2017-02-24 21:08:41 UTC) #1
JaideepBajwa
lgtm @jyan@ca.ibm.com might need your lgtm.
3 years, 10 months ago (2017-02-24 21:15:37 UTC) #2
john.yan
lgtm
3 years, 10 months ago (2017-02-24 21:51:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712193002/1
3 years, 10 months ago (2017-02-24 22:19:39 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/builds/17901) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 10 months ago (2017-02-24 22:35:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712193002/1
3 years, 10 months ago (2017-02-24 22:53:56 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: v8_linux_arm64_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/builds/17305) v8_linux_arm64_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
3 years, 10 months ago (2017-02-24 22:57:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712193002/1
3 years, 9 months ago (2017-02-27 16:24:25 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-02-27 16:50:50 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/7d1d83e52561e287c334143a9d110916dfc...

Powered by Google App Engine
This is Rietveld 408576698