Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2712123003: Revert of Add MJPEG support to FakeVideoCaptureDevice (Closed)

Created:
3 years, 10 months ago by Alexander Alekseev
Modified:
3 years, 10 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, chfremer+watch_chromium.org, feature-media-reviews_chromium.org, mcasas+watch+vc_chromium.org, xjz+watch_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add MJPEG support to FakeVideoCaptureDevice (patchset #6 id:100001 of https://codereview.chromium.org/2700173002/ ) Reason for revert: Speculative revert because of video_ChromeRTCHWDecodeUsed failure on PFQ informational builders: [4316:4316:0224/131423.612615:ERROR:v4l2_jpeg_decode_accelerator.cc(206)] Failed to open device Original issue's description: > Add MJPEG support to FakeVideoCaptureDevice > > Part of a series of CLs for FakeVideoCaptureDevice with the goal of allowing us > to expand our test coverage of the video capture pipeline. > > This CL is part of the Mojo Video Capture work. For the bigger picture, > see [1] CL12. > > BUG=584797 > TEST= > capture_unittests --gtest_filter="*Video*" > > [1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing > > Review-Url: https://codereview.chromium.org/2700173002 > Cr-Commit-Position: refs/heads/master@{#452674} > Committed: https://chromium.googlesource.com/chromium/src/+/98985be5a81f6862fa536c05cda2292a36f18e8b TBR=emircan@chromium.org,mcasas@chromium.org,guidou@chromium.org,chfremer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=584797, 696130 Review-Url: https://codereview.chromium.org/2712123003 Cr-Commit-Position: refs/heads/master@{#453071} Committed: https://chromium.googlesource.com/chromium/src/+/e9922860b23e5370570996f9aa9cb52547b0a8ef

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -255 lines) Patch
M media/capture/video/fake_video_capture_device.h View 2 chunks +1 line, -6 lines 0 comments Download
M media/capture/video/fake_video_capture_device.cc View 18 chunks +106 lines, -185 lines 0 comments Download
M media/capture/video/fake_video_capture_device_factory.cc View 4 chunks +13 lines, -26 lines 0 comments Download
M media/capture/video/fake_video_capture_device_unittest.cc View 8 chunks +20 lines, -38 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Alexander Alekseev
Created Revert of Add MJPEG support to FakeVideoCaptureDevice
3 years, 10 months ago (2017-02-25 03:33:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712123003/1
3 years, 10 months ago (2017-02-25 03:33:52 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 05:16:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e9922860b23e5370570996f9aa9c...

Powered by Google App Engine
This is Rietveld 408576698