Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 2712103003: [DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. (Closed)

Created:
3 years, 10 months ago by ymzhang1
Modified:
3 years, 9 months ago
CC:
chromium-reviews, zea+watch_chromium.org, Peter Beverloo, johnme+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, agrieve+watch_chromium.org, marq+watch_chromium.org, sync-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DirectoryOwnership] Add TEAM/COMPONENT into OWNERS files. We are adding COMPONENT/TEAM information into OWNERS file (sync, etc). Proposal to add TEAM/COMPONENT information into OWNERS files http://bit.ly/add-team-component-proposal Proposal about how to get suggested component for directory. http://bit.ly/directory-mapping-proposal TEAM-COMPONENT mapping http://bit.ly/component-team-mapping Additional Information: Component lists https://bugs.chromium.org/p/chromium/adminComponents BUG=679905 R=zea@chromium.org Review-Url: https://codereview.chromium.org/2712103003 Cr-Commit-Position: refs/heads/master@{#453663} Committed: https://chromium.googlesource.com/chromium/src/+/a1d9b2dc55999f3e2cb00e861116c2baeb398560

Patch Set 1 : Add TEAM/COMPONENT #

Total comments: 7

Patch Set 2 : update component #

Total comments: 2

Patch Set 3 : update component #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/invalidation/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/sync/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/sync_shell/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/sync/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M components/network_time/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M components/sync/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M google_apis/gcm/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/services/OWNERS View 1 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/services/gcm/OWNERS View 1 chunk +2 lines, -0 lines 0 comments Download
M ios/chrome/browser/ui/webui/gcm/OWNERS View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
ymzhang1
Hello, We are adding COMPONENT/TEAM information into OWNERS file. Would you mind helping us to ...
3 years, 10 months ago (2017-02-24 20:55:21 UTC) #2
Nicolas Zea
https://codereview.chromium.org/2712103003/diff/20001/components/network_time/OWNERS File components/network_time/OWNERS (right): https://codereview.chromium.org/2712103003/diff/20001/components/network_time/OWNERS#newcode4 components/network_time/OWNERS:4: # COMPONENT: Internals>Network Hmm, this isn't really network related. ...
3 years, 10 months ago (2017-02-24 22:50:10 UTC) #4
ymzhang1
https://codereview.chromium.org/2712103003/diff/20001/jingle/OWNERS File jingle/OWNERS (right): https://codereview.chromium.org/2712103003/diff/20001/jingle/OWNERS#newcode4 jingle/OWNERS:4: # COMPONENT: Factory On 2017/02/24 22:50:10, Nicolas Zea wrote: ...
3 years, 10 months ago (2017-02-24 22:55:48 UTC) #5
estark
https://codereview.chromium.org/2712103003/diff/20001/components/network_time/OWNERS File components/network_time/OWNERS (right): https://codereview.chromium.org/2712103003/diff/20001/components/network_time/OWNERS#newcode4 components/network_time/OWNERS:4: # COMPONENT: Internals>Network On 2017/02/24 22:50:10, Nicolas Zea wrote: ...
3 years, 9 months ago (2017-02-28 18:08:18 UTC) #6
ymzhang1
https://codereview.chromium.org/2712103003/diff/20001/components/network_time/OWNERS File components/network_time/OWNERS (right): https://codereview.chromium.org/2712103003/diff/20001/components/network_time/OWNERS#newcode4 components/network_time/OWNERS:4: # COMPONENT: Internals>Network On 2017/02/28 18:08:18, estark wrote: > ...
3 years, 9 months ago (2017-02-28 18:29:58 UTC) #7
Nicolas Zea
LGTM with one more change https://codereview.chromium.org/2712103003/diff/40001/ios/chrome/browser/ui/webui/gcm/OWNERS File ios/chrome/browser/ui/webui/gcm/OWNERS (right): https://codereview.chromium.org/2712103003/diff/40001/ios/chrome/browser/ui/webui/gcm/OWNERS#newcode6 ios/chrome/browser/ui/webui/gcm/OWNERS:6: # COMPONENT: UI>Browser>WebUI This ...
3 years, 9 months ago (2017-02-28 18:37:01 UTC) #8
ymzhang1
https://codereview.chromium.org/2712103003/diff/40001/ios/chrome/browser/ui/webui/gcm/OWNERS File ios/chrome/browser/ui/webui/gcm/OWNERS (right): https://codereview.chromium.org/2712103003/diff/40001/ios/chrome/browser/ui/webui/gcm/OWNERS#newcode6 ios/chrome/browser/ui/webui/gcm/OWNERS:6: # COMPONENT: UI>Browser>WebUI On 2017/02/28 18:37:01, Nicolas Zea wrote: ...
3 years, 9 months ago (2017-02-28 18:44:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2712103003/60001
3 years, 9 months ago (2017-02-28 18:45:25 UTC) #12
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 19:28:31 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a1d9b2dc55999f3e2cb00e861116...

Powered by Google App Engine
This is Rietveld 408576698