Enable building headless_shell in MAC. This is an initial implementation with a hidden window, rath…

Enable building headless_shell in MAC. This is an initial implementation with a hidden window, rather than "true" headless.

Note: screenshot functionality is not working. This is due to screenshots on mac being created from window bounds withing the screen, so DCHECK
fails when window is hidden. See https://cs.chromium.org/chromium/src/ui/snapshot/snapshot_mac.mm?rcl=5fa975c1785e2a47c96471691447846d1be8b51d&l=19 for actual code
BUG=687407
Review-Url: https://codereview.chromium.org/2712093002
Cr-Commit-Position: refs/heads/master@{#453147}
Committed: https://chromium.googlesource.com/chromium/src/+/1a7c4939603b40622d8dbbb65ef88de5aeb72076

[dvallet, 2017-02-24 06:11:40]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 06:11:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 06:24:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 06:24:53]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[dvallet, 2017-02-24 07:20:53]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 07:21:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 07:36:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 07:36:04]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[dvallet, 2017-02-24 09:26:11]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 09:26:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvallet, 2017-02-24 10:20:05]

dvallet@chromium.org changed reviewers:
+ samistil@chromium.org

[dvallet, 2017-02-24 10:20:06]

PTAL
I'll send a separate CL for --headless
I'm trying a fix for the snapshot issue, but I haven't find a workaround that
doesn't require changing the snapshot code in snapshot_mac.mm

[dvallet, 2017-02-24 10:20:57]

dvallet@chromium.org changed reviewers:
+ skyostil@chromium.org
- samistil@chromium.org

[dvallet, 2017-02-24 10:21:11]

PTAL
I'll send a separate CL for --headless
I'm trying a fix for the snapshot issue, but I haven't find a workaround that
doesn't require changing the snapshot code in snapshot_mac.mm

[commit-bot: I haz the power, 2017-02-24 10:23:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 10:23:29]

Dry run: This issue passed the CQ dry run.

[Sami, 2017-02-24 11:41:58]

lgtm, thanks!

https://codereview.chromium.org/2712093002/diff/60001/headless/lib/browser/he...
File headless/lib/browser/headless_content_browser_client.cc (right):

https://codereview.chromium.org/2712093002/diff/60001/headless/lib/browser/he...
headless/lib/browser/headless_content_browser_client.cc:173: #if
!defined(OS_MACOSX)
Let's use this to match the guard in the header:

#if defined(OS_POSIX) && !defined(OS_MACOSX)

https://codereview.chromium.org/2712093002/diff/60001/headless/lib/headless_c...
File headless/lib/headless_content_main_delegate.h (right):

https://codereview.chromium.org/2712093002/diff/60001/headless/lib/headless_c...
headless/lib/headless_content_main_delegate.h:42: protected:
Why protected? This looks like part of the public delegate interface.

[Sami, 2017-02-24 11:44:37]

Re: screenshots, it might be that we'll need to use some kind of offscreen
bitmap instead of a window to do rendering to make sure the window system
doesn't just throw our output away.

[dvallet, 2017-02-27 02:01:21]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 02:01:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 03:02:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 03:02:58]

Dry run: This issue passed the CQ dry run.

[dvallet, 2017-02-27 03:08:13]

On 2017/02/24 at 11:44:37, skyostil wrote:
> Re: screenshots, it might be that we'll need to use some kind of offscreen
bitmap instead of a window to do rendering to make sure the window system
doesn't just throw our output away.

I'll investigate. I've been able to make it work with fake headless in
content/shell by changing the screenshot code, but for some reason in
headless_shell all I get is a blank render with the correct size.

[dvallet, 2017-02-27 03:08:27]

The CQ bit was checked by dvallet@chromium.org

[dvallet, 2017-02-27 03:08:28]

https://codereview.chromium.org/2712093002/diff/60001/headless/lib/browser/he...
File headless/lib/browser/headless_content_browser_client.cc (right):

https://codereview.chromium.org/2712093002/diff/60001/headless/lib/browser/he...
headless/lib/browser/headless_content_browser_client.cc:173: #if
!defined(OS_MACOSX)
On 2017/02/24 at 11:41:57, Sami wrote:
> Let's use this to match the guard in the header:
> 
> #if defined(OS_POSIX) && !defined(OS_MACOSX)

Done

https://codereview.chromium.org/2712093002/diff/60001/headless/lib/headless_c...
File headless/lib/headless_content_main_delegate.h (right):

https://codereview.chromium.org/2712093002/diff/60001/headless/lib/headless_c...
headless/lib/headless_content_main_delegate.h:42: protected:
On 2017/02/24 at 11:41:57, Sami wrote:
> Why protected? This looks like part of the public delegate interface.

Sorry, moved by mistake

[dvallet, 2017-02-27 03:08:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2712093002/#ps80001
(title: "move Zygote to public")

[commit-bot: I haz the power, 2017-02-27 03:08:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 03:15:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 03:15:57]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dvallet, 2017-02-27 03:42:02]

The CQ bit was checked by dvallet@chromium.org

[dvallet, 2017-02-27 03:42:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org
Link to the patchset: https://codereview.chromium.org/2712093002/#ps100001
(title: "revet chrome/BUILD.gn")

[commit-bot: I haz the power, 2017-02-27 03:42:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvallet, 2017-02-27 03:42:19]

The CQ bit was unchecked by dvallet@chromium.org

[dvallet, 2017-02-27 03:42:20]

The CQ bit was checked by dvallet@chromium.org

[dvallet, 2017-02-27 03:42:20]

The CQ bit was unchecked by dvallet@chromium.org

[dvallet, 2017-02-27 03:42:29]

The CQ bit was checked by dvallet@chromium.org

[commit-bot: I haz the power, 2017-02-27 03:42:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 04:39:19]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1488166949016310,
"parent_rev": "9b2bb78b2d33b2a9b5441dc0a0d34d4a5b272319", "commit_rev":
"1a7c4939603b40622d8dbbb65ef88de5aeb72076"}

[commit-bot: I haz the power, 2017-02-27 04:40:22]

Description was changed from

==========
Enable building headless_shell in MAC. This is an initial implementation with a
hidden window, rather than "true" headless.

Note: screenshot functionality is not working. This is due to screenshots on mac
being created from window bounds withing the screen, so DCHECK
fails when window is hidden. See
https://cs.chromium.org/chromium/src/ui/snapshot/snapshot_mac.mm?rcl=5fa975c1...
for actual code
BUG=687407
==========

to

==========
Enable building headless_shell in MAC. This is an initial implementation with a
hidden window, rather than "true" headless.

Note: screenshot functionality is not working. This is due to screenshots on mac
being created from window bounds withing the screen, so DCHECK
fails when window is hidden. See
https://cs.chromium.org/chromium/src/ui/snapshot/snapshot_mac.mm?rcl=5fa975c1...
for actual code
BUG=687407

Review-Url: https://codereview.chromium.org/2712093002
Cr-Commit-Position: refs/heads/master@{#453147}
Committed:
https://chromium.googlesource.com/chromium/src/+/1a7c4939603b40622d8dbbb65ef8...
==========

[commit-bot: I haz the power, 2017-02-27 04:40:25]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/1a7c4939603b40622d8dbbb65ef8...