[Payment Request] Displays Contact Info in the payment summary view

[Payment Request] Displays Contact Info in the payment summary view

BUG=602666
Review-Url: https://codereview.chromium.org/2712053003
Cr-Commit-Position: refs/heads/master@{#453434}
Committed: https://chromium.googlesource.com/chromium/src/+/25df673104a75dd667bc529e201ca55a09aaf954

[Moe, 2017-02-24 23:56:32]

mahmadi@chromium.org changed reviewers:
+ lpromero@chromium.org, rouslan@chromium.org

[Moe, 2017-02-24 23:56:33]

Hi Please take a look at this CL.

[please use gerrit instead, 2017-02-26 01:55:26]

lgtm % nits

https://codereview.chromium.org/2712053003/diff/1/components/payments_strings...
File components/payments_strings.grdp (right):

https://codereview.chromium.org/2712053003/diff/1/components/payments_strings...
components/payments_strings.grdp:25: <message name="IDS_PAYMENTS_ADD_BUTTON"
desc="The generic label for an Add button." formatter_data="android_java">
Please use IDS_ADD instead.

https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?rcl=e...

https://codereview.chromium.org/2712053003/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request_view_controller.mm (right):

https://codereview.chromium.org/2712053003/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request_view_controller.mm:48: using
payment_request_util::GetEmailLabelFromAutofillProfile;
Please put these statements inside the anonymous namespace and prepend the names
with "::". This prevents polluting the global namespace and ensures you're using
the correct names.

https://codereview.chromium.org/2712053003/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/shipping_address_selection_view_controller.mm
(right):

https://codereview.chromium.org/2712053003/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/shipping_address_selection_view_controller.mm:35:
using payment_request_util::GetPhoneNumberLabelFromAutofillProfile;
Ditto

[Moe, 2017-02-27 16:43:23]

https://codereview.chromium.org/2712053003/diff/1/components/payments_strings...
File components/payments_strings.grdp (right):

https://codereview.chromium.org/2712053003/diff/1/components/payments_strings...
components/payments_strings.grdp:25: <message name="IDS_PAYMENTS_ADD_BUTTON"
desc="The generic label for an Add button." formatter_data="android_java">
On 2017/02/26 01:55:25, rouslan wrote:
> Please use IDS_ADD instead.
> 
>
https://cs.chromium.org/chromium/src/chrome/app/generated_resources.grd?rcl=e...

Done.

https://codereview.chromium.org/2712053003/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/payment_request_view_controller.mm (right):

https://codereview.chromium.org/2712053003/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/payment_request_view_controller.mm:48: using
payment_request_util::GetEmailLabelFromAutofillProfile;
On 2017/02/26 01:55:25, rouslan wrote:
> Please put these statements inside the anonymous namespace and prepend the
names
> with "::". This prevents polluting the global namespace and ensures you're
using
> the correct names.

Done.

https://codereview.chromium.org/2712053003/diff/1/ios/chrome/browser/payments...
File ios/chrome/browser/payments/shipping_address_selection_view_controller.mm
(right):

https://codereview.chromium.org/2712053003/diff/1/ios/chrome/browser/payments...
ios/chrome/browser/payments/shipping_address_selection_view_controller.mm:35:
using payment_request_util::GetPhoneNumberLabelFromAutofillProfile;
On 2017/02/26 01:55:25, rouslan wrote:
> Ditto

Done.

[lpromero, 2017-02-27 17:52:10]

lgtm with comments.

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/cells/autofill_profile_item.h (right):

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/cells/autofill_profile_item.h:14: @interface
AutofillProfileItem : CollectionViewItem
Can you add some examples to the material_cell_catalog?

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/cells/autofill_profile_item.mm (right):

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/cells/autofill_profile_item.mm:143: [_stackView
removeArrangedSubview:_nameLabel];
Wait, can't you just set the hidden property on the view? The nice secondary
benefit of the stack view is that you don't need to add/remove views.

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request_util.mm (right):

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_util.mm:33:
label_fields.push_back(autofill::COMPANY_NAME);
This is in conflict with the comment.

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request_view_controller.mm (right):

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_view_controller.mm:209: PriceItem*
paymentSummaryItem =
Why the change?

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_view_controller.mm:233: id
shippingAddressItem = nil;
You can use CollectionViewItem.

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_view_controller.mm:258: id
shippingOptionItem = nil;
Likewise.

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_view_controller.mm:321: id
contactInfoItem = nil;
Likewise for the type.

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_view_controller.mm:545: case
ItemTypeAddContactInfo:
Would this last one support being dynamically sized out of the box? (My end goal
would be to remove all use of MDCCellDefaultOneLineHeight eventually).
If any change is necessary, ignore this comment.

[Moe, 2017-02-27 20:49:43]

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/cells/autofill_profile_item.h (right):

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/cells/autofill_profile_item.h:14: @interface
AutofillProfileItem : CollectionViewItem
On 2017/02/27 17:52:10, lpromero wrote:
> Can you add some examples to the material_cell_catalog?

Done.

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/cells/autofill_profile_item.mm (right):

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/cells/autofill_profile_item.mm:143: [_stackView
removeArrangedSubview:_nameLabel];
On 2017/02/27 17:52:10, lpromero wrote:
> Wait, can't you just set the hidden property on the view? The nice secondary
> benefit of the stack view is that you don't need to add/remove views.

Done.

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request_util.mm (right):

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_util.mm:33:
label_fields.push_back(autofill::COMPANY_NAME);
On 2017/02/27 17:52:10, lpromero wrote:
> This is in conflict with the comment.

Good catch! Updated comment.

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request_view_controller.mm (right):

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_view_controller.mm:209: PriceItem*
paymentSummaryItem =
On 2017/02/27 17:52:10, lpromero wrote:
> Why the change?

After changing these references (e.g. _paymentSummaryItem) to weak references
the compiler would complain that I can't be assigning retained objects to weak
variables... hence the extra assignment.

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_view_controller.mm:233: id
shippingAddressItem = nil;
On 2017/02/27 17:52:10, lpromero wrote:
> You can use CollectionViewItem.

Done.

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_view_controller.mm:258: id
shippingOptionItem = nil;
On 2017/02/27 17:52:10, lpromero wrote:
> Likewise.

Done.

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_view_controller.mm:321: id
contactInfoItem = nil;
On 2017/02/27 17:52:10, lpromero wrote:
> Likewise for the type.

Done.

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_view_controller.mm:545: case
ItemTypeAddContactInfo:
On 2017/02/27 17:52:10, lpromero wrote:
> Would this last one support being dynamically sized out of the box? (My end
goal
> would be to remove all use of MDCCellDefaultOneLineHeight eventually).
> If any change is necessary, ignore this comment.

This one is a CollectionViewDetailItem. So it should support it. I can send out
a separate CL to update all the PR custom cell to support dynamic sizing. What
are the requirements for supporting that? Is it only updating the
preferredMaxLayoutWidth?

PS. Does preferredMaxLayoutWidth need to be set when there's only one single
line label which is attached to the edges of the cell?

[Moe, 2017-02-27 20:56:42]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-02-27 20:56:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2712053003/#ps40001
(title: "Addressed commments")

[commit-bot: I haz the power, 2017-02-27 20:57:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-27 22:15:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 22:15:45]

Failed to apply patch for
ios/chrome/browser/payments/payment_request_view_controller.mm:
While running git apply --index -p1;
  error: patch failed:
ios/chrome/browser/payments/payment_request_view_controller.mm:15
  error: ios/chrome/browser/payments/payment_request_view_controller.mm: patch
does not apply

Patch:       ios/chrome/browser/payments/payment_request_view_controller.mm
Index: ios/chrome/browser/payments/payment_request_view_controller.mm
diff --git a/ios/chrome/browser/payments/payment_request_view_controller.mm
b/ios/chrome/browser/payments/payment_request_view_controller.mm
index
07125fc63e8b0799aca358cb8d88960f304c658a..a430e88e06021162f7ec9c7e2a8b5b4ed0b17401
100644
--- a/ios/chrome/browser/payments/payment_request_view_controller.mm
+++ b/ios/chrome/browser/payments/payment_request_view_controller.mm
@@ -15,10 +15,10 @@
 #include "components/autofill/core/browser/personal_data_manager.h"
 #include "components/payments/currency_formatter.h"
 #include "components/strings/grit/components_strings.h"
+#import "ios/chrome/browser/payments/cells/autofill_profile_item.h"
 #import "ios/chrome/browser/payments/cells/page_info_item.h"
 #import "ios/chrome/browser/payments/cells/payment_method_item.h"
 #import "ios/chrome/browser/payments/cells/price_item.h"
-#import "ios/chrome/browser/payments/cells/shipping_address_item.h"
 #import "ios/chrome/browser/payments/payment_request_util.h"
 #import "ios/chrome/browser/payments/payment_request_view_controller_actions.h"
 #import "ios/chrome/browser/ui/autofill/cells/status_item.h"
@@ -42,9 +42,12 @@
 #error "This file requires ARC support."
 #endif
 
-using payment_request_util::NameLabelFromAutofillProfile;
-using payment_request_util::AddressLabelFromAutofillProfile;
-using payment_request_util::PhoneNumberLabelFromAutofillProfile;
+namespace {
+using ::payment_request_util::GetNameLabelFromAutofillProfile;
+using ::payment_request_util::GetAddressLabelFromAutofillProfile;
+using ::payment_request_util::GetPhoneNumberLabelFromAutofillProfile;
+using ::payment_request_util::GetEmailLabelFromAutofillProfile;
+}  // namespace
 
 NSString* const kPaymentRequestCollectionViewID =
     @"kPaymentRequestCollectionViewID";
@@ -58,7 +61,7 @@ typedef NS_ENUM(NSInteger, SectionIdentifier) {
   SectionIdentifierSummary = kSectionIdentifierEnumZero,
   SectionIdentifierShipping,
   SectionIdentifierPayment,
-
+  SectionIdentifierContactInfo,
 };
 
 typedef NS_ENUM(NSInteger, ItemType) {
@@ -73,6 +76,9 @@ typedef NS_ENUM(NSInteger, ItemType) {
   ItemTypePaymentTitle,
   ItemTypePaymentMethod,
   ItemTypeAddPaymentMethod,
+  ItemTypeContactInfoTitle,
+  ItemTypeContactInfo,
+  ItemTypeAddContactInfo,
 };
 
 }  // namespace
@@ -87,10 +93,11 @@ typedef NS_ENUM(NSInteger, ItemType) {
   // pointer and should outlive this class.
   PaymentRequest* _paymentRequest;
 
-  PriceItem* _paymentSummaryItem;
-  ShippingAddressItem* _selectedShippingAddressItem;
-  CollectionViewTextItem* _selectedShippingOptionItem;
-  PaymentMethodItem* _selectedPaymentMethodItem;
+  __weak PriceItem* _paymentSummaryItem;
+  __weak AutofillProfileItem* _selectedShippingAddressItem;
+  __weak CollectionViewTextItem* _selectedShippingOptionItem;
+  __weak PaymentMethodItem* _selectedPaymentMethodItem;
+  __weak AutofillProfileItem* _selectedContactInfoItem;
 }
 
 @end
@@ -110,8 +117,7 @@ typedef NS_ENUM(NSInteger, ItemType) {
 
     // Set up leading (cancel) button.
     _cancelButton = [[UIBarButtonItem alloc]
-        initWithTitle:l10n_util::GetNSString(
-                          IDS_IOS_PAYMENT_REQUEST_CANCEL_BUTTON)
+        initWithTitle:l10n_util::GetNSString(IDS_CANCEL)
                 style:UIBarButtonItemStylePlain
                target:nil
                action:@selector(onCancel)];
@@ -200,16 +206,18 @@ typedef NS_ENUM(NSInteger, ItemType) {
     return;
   }
 
-  _paymentSummaryItem = [[PriceItem alloc] initWithType:ItemTypeSummaryTotal];
-  [self fillPaymentSummaryItem:_paymentSummaryItem
+  PriceItem* paymentSummaryItem =
+      [[PriceItem alloc] initWithType:ItemTypeSummaryTotal];
+  _paymentSummaryItem = paymentSummaryItem;
+  [self fillPaymentSummaryItem:paymentSummaryItem
                withPaymentItem:_paymentRequest->payment_details().total
          withTotalValueChanged:NO];
   if (!_paymentRequest->payment_details().display_items.empty()) {
-    _paymentSummaryItem.accessoryType =
+    paymentSummaryItem.accessoryType =
         MDCCollectionViewCellAccessoryDisclosureIndicator;
-    _paymentSummaryItem.accessibilityTraits |= UIAccessibilityTraitButton;
+    paymentSummaryItem.accessibilityTraits |= UIAccessibilityTraitButton;
   }
-  [model addItem:_paymentSummaryItem
+  [model addItem:paymentSummaryItem
       toSectionWithIdentifier:SectionIdentifierSummary];
 
   // Shipping section.
@@ -224,37 +232,41 @@ typedef NS_ENUM(NSInteger, ItemType) {
 
   CollectionViewItem* shippingAddressItem = nil;
   if (_paymentRequest->selected_shipping_profile()) {
-    _selectedShippingAddressItem =
-        [[ShippingAddressItem alloc] initWithType:ItemTypeShippingAddress];
-    shippingAddressItem = _selectedShippingAddressItem;
-    [self fillShippingAddressItem:_selectedShippingAddressItem
-                     
withAddress:_paymentRequest->selected_shipping_profile()];
-    _selectedShippingAddressItem.accessoryType =
+    AutofillProfileItem* selectedShippingAddressItem =
+        [[AutofillProfileItem alloc] initWithType:ItemTypeShippingAddress];
+    shippingAddressItem = selectedShippingAddressItem;
+    _selectedShippingAddressItem = selectedShippingAddressItem;
+    [self fillShippingAddressItem:selectedShippingAddressItem
+             
withAutofillProfile:_paymentRequest->selected_shipping_profile()];
+    selectedShippingAddressItem.accessoryType =
         MDCCollectionViewCellAccessoryDisclosureIndicator;
-
+    selectedShippingAddressItem.accessibilityTraits |=
+        UIAccessibilityTraitButton;
   } else {
     CollectionViewDetailItem* addAddressItem = [[CollectionViewDetailItem
alloc]
         initWithType:ItemTypeAddShippingAddress];
     shippingAddressItem = addAddressItem;
     addAddressItem.text =
         payment_request_util::GetShippingAddressSelectorTitle(_paymentRequest);
-    addAddressItem.detailText = [l10n_util::GetNSString(
-        IDS_IOS_PAYMENT_REQUEST_ADD_SHIPPING_ADDRESS_BUTTON)
+    addAddressItem.detailText = [l10n_util::GetNSString(IDS_ADD)
         uppercaseStringWithLocale:[NSLocale currentLocale]];
+    addAddressItem.accessibilityTraits |= UIAccessibilityTraitButton;
   }
-  shippingAddressItem.accessibilityTraits |= UIAccessibilityTraitButton;
   [model addItem:shippingAddressItem
       toSectionWithIdentifier:SectionIdentifierShipping];
 
   CollectionViewItem* shippingOptionItem = nil;
   if (_paymentRequest->selected_shipping_option()) {
-    _selectedShippingOptionItem =
+    CollectionViewTextItem* selectedShippingOptionItem =
         [[CollectionViewTextItem alloc] initWithType:ItemTypeShippingOption];
-    shippingOptionItem = _selectedShippingOptionItem;
-    [self fillShippingOptionItem:_selectedShippingOptionItem
+    shippingOptionItem = selectedShippingOptionItem;
+    _selectedShippingOptionItem = selectedShippingOptionItem;
+    [self fillShippingOptionItem:selectedShippingOptionItem
                       withOption:_paymentRequest->selected_shipping_option()];
-    _selectedShippingOptionItem.accessoryType =
+    selectedShippingOptionItem.accessoryType =
         MDCCollectionViewCellAccessoryDisclosureIndicator;
+    selectedShippingOptionItem.accessibilityTraits |=
+        UIAccessibilityTraitButton;
   } else {
     CollectionViewDetailItem* selectShippingOptionItem =
         [[CollectionViewDetailItem alloc]
@@ -264,8 +276,8 @@ typedef NS_ENUM(NSInteger, ItemType) {
         payment_request_util::GetShippingOptionSelectorTitle(_paymentRequest);
     selectShippingOptionItem.accessoryType =
         MDCCollectionViewCellAccessoryDisclosureIndicator;
+    selectShippingOptionItem.accessibilityTraits |= UIAccessibilityTraitButton;
   }
-  shippingOptionItem.accessibilityTraits |= UIAccessibilityTraitButton;
   [model addItem:shippingOptionItem
       toSectionWithIdentifier:SectionIdentifierShipping];
 
@@ -277,30 +289,65 @@ typedef NS_ENUM(NSInteger, ItemType) {
     CollectionViewTextItem* paymentTitle =
         [[CollectionViewTextItem alloc] initWithType:ItemTypePaymentTitle];
     paymentTitle.text =
-        l10n_util::GetNSString(IDS_IOS_PAYMENT_REQUEST_PAYMENT_METHOD_HEADER);
+        l10n_util::GetNSString(IDS_PAYMENTS_METHOD_OF_PAYMENT_LABEL);
     [model setHeader:paymentTitle
         forSectionWithIdentifier:SectionIdentifierPayment];
 
-    _selectedPaymentMethodItem =
+    PaymentMethodItem* selectedPaymentMethodItem =
         [[PaymentMethodItem alloc] initWithType:ItemTypePaymentMethod];
-    paymentMethodItem = _selectedPaymentMethodItem;
-    [self fillPaymentMethodItem:_selectedPaymentMethodItem
-              withPaymentMethod:_paymentRequest->selected_credit_card()];
-    _selectedPaymentMethodItem.accessoryType =
+    paymentMethodItem = selectedPaymentMethodItem;
+    _selectedPaymentMethodItem = selectedPaymentMethodItem;
+    [self fillPaymentMethodItem:selectedPaymentMethodItem
+                 withCreditCard:_paymentRequest->selected_credit_card()];
+    selectedPaymentMethodItem.accessoryType =
         MDCCollectionViewCellAccessoryDisclosureIndicator;
+    selectedPaymentMethodItem.accessibilityTraits |=
UIAccessibilityTraitButton;
   } else {
     CollectionViewDetailItem* addPaymentMethodItem = [
         [CollectionViewDetailItem alloc]
initWithType:ItemTypeAddPaymentMethod];
     paymentMethodItem = addPaymentMethodItem;
     addPaymentMethodItem.text =
-        l10n_util::GetNSString(IDS_IOS_PAYMENT_REQUEST_PAYMENT_METHOD_HEADER);
-    addPaymentMethodItem.detailText = [l10n_util::GetNSString(
-        IDS_IOS_PAYMENT_REQUEST_ADD_SHIPPING_ADDRESS…
(message too large)

[Moe, 2017-02-27 23:40:26]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2017-02-27 23:40:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
rouslan@chromium.org, lpromero@chromium.org
Link to the patchset: https://codereview.chromium.org/2712053003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2017-02-27 23:40:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 01:15:41]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1488238826872080,
"parent_rev": "9967d360b1bdd6c7317c3cbe1e1d9c2b3aea677e", "commit_rev":
"25df673104a75dd667bc529e201ca55a09aaf954"}

[commit-bot: I haz the power, 2017-02-28 01:17:10]

Description was changed from

==========
[Payment Request] Displays Contact Info in the payment summary view

BUG=602666
==========

to

==========
[Payment Request] Displays Contact Info in the payment summary view

BUG=602666

Review-Url: https://codereview.chromium.org/2712053003
Cr-Commit-Position: refs/heads/master@{#453434}
Committed:
https://chromium.googlesource.com/chromium/src/+/25df673104a75dd667bc529e201c...
==========

[commit-bot: I haz the power, 2017-02-28 01:17:12]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/25df673104a75dd667bc529e201c...

[lpromero, 2017-02-28 10:03:05]

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
File ios/chrome/browser/payments/payment_request_view_controller.mm (right):

https://codereview.chromium.org/2712053003/diff/20001/ios/chrome/browser/paym...
ios/chrome/browser/payments/payment_request_view_controller.mm:545: case
ItemTypeAddContactInfo:
On 2017/02/27 20:49:43, moe wrote:
> On 2017/02/27 17:52:10, lpromero wrote:
> > Would this last one support being dynamically sized out of the box? (My end
> goal
> > would be to remove all use of MDCCellDefaultOneLineHeight eventually).
> > If any change is necessary, ignore this comment.
> 
> This one is a CollectionViewDetailItem. So it should support it. I can send
out
> a separate CL to update all the PR custom cell to support dynamic sizing. What
> are the requirements for supporting that? Is it only updating the
> preferredMaxLayoutWidth?
> 
> PS. Does preferredMaxLayoutWidth need to be set when there's only one single
> line label which is attached to the edges of the cell?

preferredMaxLayoutWidth is only for multilines labels. For single line, it's
indeed constraints with edges.
The cases that don't support dynamic yet:
- MDCCollectionViewTextCell, as it doesn't use Autolayout.
- other cells that center their content instead of attaching it to the edges.
For these, there is no constraint on the height, so it returns 0! The solution
has you point at is to constrain the edges.

That would be great if all the payments cells supported dynamic sizing. One day
I want to move -collectionView:cellHeightAtIndexPath: in the parent class.