Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: third_party/WebKit/Source/core/frame/LocalFrameClient.h

Issue 2712033002: Part 1 Of Renaming FrameLoaderClient to LocalFrameClient. (Closed)
Patch Set: Change all forward declarations of FrameLoaderClient to LocalFrameClient and fix call sites. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/LocalFrameClient.h
diff --git a/third_party/WebKit/Source/core/loader/FrameLoaderClient.h b/third_party/WebKit/Source/core/frame/LocalFrameClient.h
similarity index 97%
copy from third_party/WebKit/Source/core/loader/FrameLoaderClient.h
copy to third_party/WebKit/Source/core/frame/LocalFrameClient.h
index 613354db7b3126a3c6df7672e454fd0fcbd75a73..aeaac63d6065c42de3ff9bc18f03293118a1180c 100644
--- a/third_party/WebKit/Source/core/loader/FrameLoaderClient.h
+++ b/third_party/WebKit/Source/core/frame/LocalFrameClient.h
@@ -28,11 +28,11 @@
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/
-#ifndef FrameLoaderClient_h
-#define FrameLoaderClient_h
+#ifndef LocalFrameClient_h
+#define LocalFrameClient_h
-#include <v8.h>
#include <memory>
+
#include "core/CoreExport.h"
#include "core/dom/Document.h"
#include "core/dom/IconURL.h"
@@ -52,6 +52,7 @@
#include "public/platform/WebFeaturePolicy.h"
#include "public/platform/WebInsecureRequestPolicy.h"
#include "public/platform/WebLoadingBehaviorFlag.h"
+#include "v8/include/v8.h"
#include "wtf/Forward.h"
#include "wtf/Vector.h"
@@ -85,9 +86,9 @@ class WebRTCPeerConnectionHandler;
class WebServiceWorkerProvider;
class Widget;
-class CORE_EXPORT FrameLoaderClient : public FrameClient {
+class CORE_EXPORT LocalFrameClient : public FrameClient {
public:
- ~FrameLoaderClient() override {}
+ ~LocalFrameClient() override {}
virtual bool hasWebView() const = 0; // mainly for assertions
@@ -218,8 +219,7 @@ class CORE_EXPORT FrameLoaderClient : public FrameClient {
virtual void runScriptsAtDocumentElementAvailable() = 0;
virtual void runScriptsAtDocumentReady(bool documentIsEmpty) = 0;
- virtual void didCreateScriptContext(v8::Local<v8::Context>,
- int worldId) = 0;
+ virtual void didCreateScriptContext(v8::Local<v8::Context>, int worldId) = 0;
virtual void willReleaseScriptContext(v8::Local<v8::Context>,
int worldId) = 0;
virtual bool allowScriptExtensions() = 0;
@@ -314,7 +314,7 @@ class CORE_EXPORT FrameLoaderClient : public FrameClient {
virtual unsigned backForwardLength() { return 0; }
- virtual bool isFrameLoaderClientImpl() const { return false; }
+ virtual bool isLocalFrameClientImpl() const { return false; }
// Called when elements preventing the sudden termination of the frame become
// present or stop being present. |type| is the type of element (BeforeUnload
@@ -347,4 +347,4 @@ class CORE_EXPORT FrameLoaderClient : public FrameClient {
} // namespace blink
-#endif // FrameLoaderClient_h
+#endif // LocalFrameClient_h

Powered by Google App Engine
This is Rietveld 408576698