Ensure PeopleHandler only calls PSS::RequestStart in response to intention to configure sync

Ensure PeopleHandler only calls PSS::RequestStart in response to intention to configure sync

Currently PSS::RequestStart is called from PushSyncPrefs() which can be
triggered by internal sync state changes. This call unsuppresses sync.

Instead PSS::RequestStart should be called only in response to user actions to
configure sync. I think OpenSyncSetup() is a good place.

BUG=694762
R=tommycli@chromium.org

Review-Url: https://codereview.chromium.org/2711993002
Cr-Commit-Position: refs/heads/master@{#453457}
Committed: https://chromium.googlesource.com/chromium/src/+/a6f225f3f8a8fb31228e038217484ffff259463c

[pavely, 2017-02-23 22:09:55]

The CQ bit was checked by pavely@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 22:10:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 23:05:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 23:05:28]

Dry run: This issue passed the CQ dry run.

[tommycli, 2017-02-27 21:45:08]

lgtm, btw, you also manually tested this?

[tommycli, 2017-02-27 21:46:04]

one comment

https://codereview.chromium.org/2711993002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/people_handler.cc (right):

https://codereview.chromium.org/2711993002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/people_handler.cc:793: return;
I think you will have to move this early-exit to the above point also.

[pavely, 2017-02-28 01:02:56]

Yes, I tested following scenarios:
- Sync doesn't get restarted after resetting sync if md-settings page is open
- Sync stays disabled after restart when opening md-settings.
- Sync engine gets initialized and sync gets reenabled after restart after
clicking on sync option in settings

https://codereview.chromium.org/2711993002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/people_handler.cc (right):

https://codereview.chromium.org/2711993002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/people_handler.cc:793: return;
On 2017/02/27 21:46:04, tommycli wrote:
> I think you will have to move this early-exit to the above point also.

Yes, you are right.
Done.

[pavely, 2017-02-28 01:03:06]

The CQ bit was checked by pavely@chromium.org

[pavely, 2017-02-28 01:03:06]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2711993002/#ps20001
(title: "Address comment")

[commit-bot: I haz the power, 2017-02-28 01:04:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 02:15:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488243786209470,
"parent_rev": "e3a08e0c72b10c81f8fdfe3420871f265c6a66af", "commit_rev":
"a6f225f3f8a8fb31228e038217484ffff259463c"}

[commit-bot: I haz the power, 2017-02-28 02:16:10]

Description was changed from

==========
Ensure PeopleHandler only calls PSS::RequestStart in response to intention to
configure sync

Currently PSS::RequestStart is called from PushSyncPrefs() which can be
triggered by internal sync state changes. This call unsuppresses sync.

Instead PSS::RequestStart should be called only in response to user actions to
configure sync. I think OpenSyncSetup() is a good place.

BUG=694762
R=tommycli@chromium.org
==========

to

==========
Ensure PeopleHandler only calls PSS::RequestStart in response to intention to
configure sync

Currently PSS::RequestStart is called from PushSyncPrefs() which can be
triggered by internal sync state changes. This call unsuppresses sync.

Instead PSS::RequestStart should be called only in response to user actions to
configure sync. I think OpenSyncSetup() is a good place.

BUG=694762
R=tommycli@chromium.org

Review-Url: https://codereview.chromium.org/2711993002
Cr-Commit-Position: refs/heads/master@{#453457}
Committed:
https://chromium.googlesource.com/chromium/src/+/a6f225f3f8a8fb31228e03821748...
==========

[commit-bot: I haz the power, 2017-02-28 02:16:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a6f225f3f8a8fb31228e03821748...