Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2711913005:
Retry SuggestionsBottomSheetTest.testContextMenu on chromium.android/Lollipop (Closed)
DescriptionRetry SuggestionsBottomSheetTest.testContextMenu on chromium.android/Lollipop
BUG=695802
TBR=dfalcantara@chromium.org
Review-Url: https://codereview.chromium.org/2711913005
Cr-Commit-Position: refs/heads/master@{#452811}
Committed: https://chromium.googlesource.com/chromium/src/+/8cfa3aea98435616307c4a1764d76992c7f5026c
Patch Set 1 #
Total comments: 1
Patch Set 2 : retry instead of disable #
Messages
Total messages: 21 (12 generated)
mattcary@chromium.org changed reviewers: + lizeb@google.com
Could you take a quick look at this before I TBR it to an owner? I'm not familiar with java tests. It compiles, but I haven't otherwise tested it. This is the git cl format version. The presubmit wants the line testContextMenu() indented an additional 8 spaces.
mvanouwerkerk@chromium.org changed reviewers: + dgn@chromium.org
https://codereview.chromium.org/2711913005/diff/1/chrome/android/javatests/sr... File chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java (right): https://codereview.chromium.org/2711913005/diff/1/chrome/android/javatests/sr... chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java:46: @DisableIf.Build(sdk_is_greater_than = 20, sdk_is_less_than = 23, Could we use @RetryOnFailure instead of disabling it?
On 2017/02/24 12:58:26, Michael van Ouwerkerk wrote: > https://codereview.chromium.org/2711913005/diff/1/chrome/android/javatests/sr... > File > chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java > (right): > > https://codereview.chromium.org/2711913005/diff/1/chrome/android/javatests/sr... > chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java:46: > @DisableIf.Build(sdk_is_greater_than = 20, sdk_is_less_than = 23, > Could we use @RetryOnFailure instead of disabling it? Yeah, good idea.
Description was changed from ========== Disable SuggestionsBottomSheetTest.testContextMenu on chromium.android/Lollipop NOPRESUBMIT=true BUG=695802 ========== to ========== Disable SuggestionsBottomSheetTest.testContextMenu on chromium.android/Lollipop BUG=695802 ==========
On 2017/02/24 13:01:47, mattcary wrote: > On 2017/02/24 12:58:26, Michael van Ouwerkerk wrote: > > > https://codereview.chromium.org/2711913005/diff/1/chrome/android/javatests/sr... > > File > > > chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java > > (right): > > > > > https://codereview.chromium.org/2711913005/diff/1/chrome/android/javatests/sr... > > > chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/SuggestionsBottomSheetTest.java:46: > > @DisableIf.Build(sdk_is_greater_than = 20, sdk_is_less_than = 23, > > Could we use @RetryOnFailure instead of disabling it? > > Yeah, good idea. I guess if you're an owner, Michael, you could lgtm if it looks okay now rather than TBR'ing.
mvanouwerkerk@chromium.org changed reviewers: + mvanouwerkerk@chromium.org
lgtm
The CQ bit was checked by mattcary@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Disable SuggestionsBottomSheetTest.testContextMenu on chromium.android/Lollipop BUG=695802 ========== to ========== Retry SuggestionsBottomSheetTest.testContextMenu on chromium.android/Lollipop BUG=695802 ==========
mattcary@chromium.org changed reviewers: + dfalcantara@chromium.org - lizeb@google.com
Description was changed from ========== Retry SuggestionsBottomSheetTest.testContextMenu on chromium.android/Lollipop BUG=695802 ========== to ========== Retry SuggestionsBottomSheetTest.testContextMenu on chromium.android/Lollipop BUG=695802 TBR=dfalcantara@chromium.org ==========
The CQ bit was checked by mattcary@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487943818412060,
"parent_rev": "54e53ba552010362d70b70fc4e68eb5f939958ca", "commit_rev":
"8cfa3aea98435616307c4a1764d76992c7f5026c"}
Message was sent while issue was closed.
Description was changed from ========== Retry SuggestionsBottomSheetTest.testContextMenu on chromium.android/Lollipop BUG=695802 TBR=dfalcantara@chromium.org ========== to ========== Retry SuggestionsBottomSheetTest.testContextMenu on chromium.android/Lollipop BUG=695802 TBR=dfalcantara@chromium.org Review-Url: https://codereview.chromium.org/2711913005 Cr-Commit-Position: refs/heads/master@{#452811} Committed: https://chromium.googlesource.com/chromium/src/+/8cfa3aea98435616307c4a1764d7... ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/8cfa3aea98435616307c4a1764d7... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
