Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics (Closed)
Patch Set: add tests, rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 84630b481d6adeeb90e61be86c090eb3cb8f0185..5b7307a8a19e192f868d5697dbc1b9e35624a7db 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -20283,6 +20283,25 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
</summary>
</histogram>
+<histogram name="FirstMeaningfulPaintDetector.FirstMeaningfulPaintOrdering"
Ilya Sherman 2017/03/08 09:19:46 Would it be appropriate to group these new histogr
Kunihiko Sakamoto 2017/03/08 10:16:10 I wanted to separate these from PageLoad.* metrics
Ilya Sherman 2017/03/08 22:46:45 What about something like "PageLoad.Experimental.R
Kunihiko Sakamoto 2017/03/10 04:37:10 Renamed to "PageLoad.Experimental.Renderer.FirstMe
+ enum="FirstMeaningfulPaintOrdering">
+ <owner>ksakamoto@chromium.org</owner>
+ <summary>
+ Whether the two variants of First Meaningful Paint reported different value,
Ilya Sherman 2017/03/08 09:19:46 nit: s/value/values
Kunihiko Sakamoto 2017/03/08 10:16:10 Done.
+ and if so, which one was reported first.
+ </summary>
+</histogram>
+
+<histogram name="FirstMeaningfulPaintDetector.HadNetworkQuiet"
+ enum="NetworkQuietStatus">
+ <owner>ksakamoto@chromium.org</owner>
+ <summary>
+ Recorded when the page load reached network 0-stable (no active network
+ connection for 0.5 seconds), or network 2-stable (no more than 2 active
+ network connections for 2 seconds).
Ilya Sherman 2017/03/08 09:19:46 Would it be useful to also record when a page neve
Kunihiko Sakamoto 2017/03/08 10:16:10 Unfortunately it's hard (if not impossible) to rec
Ilya Sherman 2017/03/08 22:46:45 Okay. In that case, could you please include a re
Kunihiko Sakamoto 2017/03/10 04:37:10 Done.
+ </summary>
+</histogram>
+
<histogram base="true" name="FirstUserAction.BackgroundTime.MainIntent"
units="minutes">
<owner>tedchoc@chromium.org</owner>
@@ -93938,6 +93957,12 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.
<int value="20" label=".log"/>
</enum>
+<enum name="FirstMeaningfulPaintOrdering" type="int">
+ <int value="0" label="FMP 0-quiet &lt; FMP 2-quiet"/>
+ <int value="1" label="FMP 0-quiet &gt; FMP 2-quiet"/>
+ <int value="2" label="FMP 0-quiet = FMP 2-quiet"/>
+</enum>
+
<enum name="FirstMeaningfulPaintSignalStatus" type="int">
<int value="0" label="No input, network active"/>
<int value="1" label="Had input, network active"/>
@@ -102235,6 +102260,11 @@ from previous Chrome versions.
<int value="6" label="Channel Type Change"/>
</enum>
+<enum name="NetworkQuietStatus" type="int">
+ <int value="0" label="Had network 0-quiet for 0.5 seconds"/>
+ <int value="1" label="Had network 2-quiet for 2 seconds"/>
+</enum>
+
<enum name="NetworkSecurityType" type="int">
<summary>
The security types come from the connman_service_security enum in

Powered by Google App Engine
This is Rietveld 408576698