third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp - Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

Issue 2711893002: Loosen FirstMeaningfulPaint UMA network-idle heuristics (Closed)

Patch Set: add tests, rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp ('K') | « third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

diff --git a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

index c9f7f26c3ae22ddc0fc923067889546e1db2eda9..a76fb7c70d7da4a151892eaede7f3efb184dad81 100644

--- a/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

+++ b/third_party/WebKit/Source/platform/loader/fetch/ResourceFetcher.cpp

@@ -1060,12 +1060,12 @@ void ResourceFetcher::clearContext() {

m_context.clear();

}

-int ResourceFetcher::requestCount() const {

+int ResourceFetcher::blockingRequestCount() const {

return m_loaders.size();

}

-bool ResourceFetcher::hasPendingRequest() const {

- return m_loaders.size() > 0 || m_nonBlockingLoaders.size() > 0;

+int ResourceFetcher::nonblockingRequestCount() const {

+ return m_nonBlockingLoaders.size();

}

void ResourceFetcher::preloadStarted(Resource* resource) {