Fix a crash due to reentrancy in the widget while processing a theme changed notification after com…

Merging to M57

Fix a crash due to reentrancy in the widget while processing a theme changed notification after coming out of fullscreen mode

The crash occurs as views are removed/added while we are propagating theme changed notifications to the view hierarchy.

Proposed fix is to add a recursion guard flag processing_theme_changed_ which is set in
Widget::OnNativeThemeUpdated before propagating the theme changed notification and reset after
the function returns. We check the flag in Widget::FrameTypeChanged() and bail. This function is called becaue
Widget is registered as an observer on the BrowserView.

BUG=681525
TBR=sky
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2703933002
Cr-Commit-Position: refs/heads/master@{#451505}
(cherry picked from commit f7c7217dd882eac40d5d07e441db5ef9fe3c94a4)

Review-Url: https://codereview.chromium.org/2711853004
Cr-Commit-Position: refs/branch-heads/2987@{#670}
Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed: https://chromium.googlesource.com/chromium/src/+/feff536f7394156055e3c86df0dd5901e2f49bb2

[ananta, 2017-02-23 22:18:44]

Description was changed from

==========
Fix a crash due to reentrancy in the widget while processing a theme changed
notification after coming out of fullscreen mode

The crash occurs as views are removed/added while we are propagating theme
changed notifications to the view hierarchy.

Proposed fix is to add a recursion guard flag processing_theme_changed_ which is
set in
Widget::OnNativeThemeUpdated before propagating the theme changed notification
and reset after
the function returns. We check the flag in Widget::FrameTypeChanged() and bail.
This function is called becaue
Widget is registered as an observer on the BrowserView.

BUG=681525

Review-Url: https://codereview.chromium.org/2703933002
Cr-Commit-Position: refs/heads/master@{#451505}
(cherry picked from commit f7c7217dd882eac40d5d07e441db5ef9fe3c94a4)
==========

to

==========
Merging to M57

Fix a crash due to reentrancy in the widget while processing a theme changed
notification after coming out of fullscreen mode

The crash occurs as views are removed/added while we are propagating theme
changed notifications to the view hierarchy.

Proposed fix is to add a recursion guard flag processing_theme_changed_ which is
set in
Widget::OnNativeThemeUpdated before propagating the theme changed notification
and reset after
the function returns. We check the flag in Widget::FrameTypeChanged() and bail.
This function is called becaue
Widget is registered as an observer on the BrowserView.

BUG=681525
TBR=sky

Review-Url: https://codereview.chromium.org/2703933002
Cr-Commit-Position: refs/heads/master@{#451505}
(cherry picked from commit f7c7217dd882eac40d5d07e441db5ef9fe3c94a4)
==========

[ananta, 2017-02-23 22:18:44]

ananta@chromium.org changed reviewers:
+ sky@chromium.org

[ananta, 2017-02-23 22:23:04]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-02-23 22:23:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 22:23:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 22:23:52]

CLs for remote refs other than refs/heads/master must contain NOTRY=true and
NOPRESUBMIT=true in order for the CQ to process them

[ananta, 2017-02-23 22:25:12]

Description was changed from

==========
Merging to M57

Fix a crash due to reentrancy in the widget while processing a theme changed
notification after coming out of fullscreen mode

The crash occurs as views are removed/added while we are propagating theme
changed notifications to the view hierarchy.

Proposed fix is to add a recursion guard flag processing_theme_changed_ which is
set in
Widget::OnNativeThemeUpdated before propagating the theme changed notification
and reset after
the function returns. We check the flag in Widget::FrameTypeChanged() and bail.
This function is called becaue
Widget is registered as an observer on the BrowserView.

BUG=681525
TBR=sky

Review-Url: https://codereview.chromium.org/2703933002
Cr-Commit-Position: refs/heads/master@{#451505}
(cherry picked from commit f7c7217dd882eac40d5d07e441db5ef9fe3c94a4)
==========

to

==========
Merging to M57

Fix a crash due to reentrancy in the widget while processing a theme changed
notification after coming out of fullscreen mode

The crash occurs as views are removed/added while we are propagating theme
changed notifications to the view hierarchy.

Proposed fix is to add a recursion guard flag processing_theme_changed_ which is
set in
Widget::OnNativeThemeUpdated before propagating the theme changed notification
and reset after
the function returns. We check the flag in Widget::FrameTypeChanged() and bail.
This function is called becaue
Widget is registered as an observer on the BrowserView.

BUG=681525
TBR=sky
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2703933002
Cr-Commit-Position: refs/heads/master@{#451505}
(cherry picked from commit f7c7217dd882eac40d5d07e441db5ef9fe3c94a4)
==========

[ananta, 2017-02-23 22:25:16]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2017-02-23 22:26:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 22:28:04]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487888716647000, "parent_rev":
"00cba58434f9de8c8118d2b71c56035c5ac22fbe", "commit_rev":
"feff536f7394156055e3c86df0dd5901e2f49bb2"}

[commit-bot: I haz the power, 2017-02-23 22:28:46]

Description was changed from

==========
Merging to M57

Fix a crash due to reentrancy in the widget while processing a theme changed
notification after coming out of fullscreen mode

The crash occurs as views are removed/added while we are propagating theme
changed notifications to the view hierarchy.

Proposed fix is to add a recursion guard flag processing_theme_changed_ which is
set in
Widget::OnNativeThemeUpdated before propagating the theme changed notification
and reset after
the function returns. We check the flag in Widget::FrameTypeChanged() and bail.
This function is called becaue
Widget is registered as an observer on the BrowserView.

BUG=681525
TBR=sky
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2703933002
Cr-Commit-Position: refs/heads/master@{#451505}
(cherry picked from commit f7c7217dd882eac40d5d07e441db5ef9fe3c94a4)
==========

to

==========
Merging to M57

Fix a crash due to reentrancy in the widget while processing a theme changed
notification after coming out of fullscreen mode

The crash occurs as views are removed/added while we are propagating theme
changed notifications to the view hierarchy.

Proposed fix is to add a recursion guard flag processing_theme_changed_ which is
set in
Widget::OnNativeThemeUpdated before propagating the theme changed notification
and reset after
the function returns. We check the flag in Widget::FrameTypeChanged() and bail.
This function is called becaue
Widget is registered as an observer on the BrowserView.

BUG=681525
TBR=sky
NOTRY=true
NOPRESUBMIT=true

Review-Url: https://codereview.chromium.org/2703933002
Cr-Commit-Position: refs/heads/master@{#451505}
(cherry picked from commit f7c7217dd882eac40d5d07e441db5ef9fe3c94a4)

Review-Url: https://codereview.chromium.org/2711853004
Cr-Commit-Position: refs/branch-heads/2987@{#670}
Cr-Branched-From:
ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943}
Committed:
https://chromium.googlesource.com/chromium/src/+/feff536f7394156055e3c86df0dd...
==========

[commit-bot: I haz the power, 2017-02-23 22:28:47]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/feff536f7394156055e3c86df0dd...