Issue 2711843003: Fix summarize const expression logic to be compatible with Dart2JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2711843003: Fix summarize const expression logic to be compatible with Dart2JS. (Closed)

Created:
3 years, 10 months ago by Jacob

Modified:
3 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org, sra1

Target Ref:
refs/heads/master

Visibility:
Public.

Fix summarize const expression logic to be compatible with Dart2JS. Shifting by 32 bits is not safe when compiling to JavaScript. BUG= R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/e36efc72d2df0d731479b90effabd7b2ce51fadc

Created: 3 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	pkg/analyzer/lib/src/summary/summarize_const_expr.dart	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (2 generated)

Jacob

Shifting by 32 bits is not safe when compiling to JavaScript. Sra wrote this code ...

3 years, 10 months ago (2017-02-23 18:09:05 UTC) #2

Jacob

3 years, 10 months ago (2017-02-23 19:02:17 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e36efc72d2df0d731479b90effabd7b2ce51fadc (presubmit successful).