Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Unified Diff: pkg/analyzer/lib/src/summary/summarize_const_expr.dart

Issue 2711843003: Fix summarize const expression logic to be compatible with Dart2JS. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/lib/src/summary/summarize_const_expr.dart
diff --git a/pkg/analyzer/lib/src/summary/summarize_const_expr.dart b/pkg/analyzer/lib/src/summary/summarize_const_expr.dart
index 46b69582fc0f4300576ac0a8a6e059fbe1c1c93d..fc3184bf0cc53e0dbab1eb7e7048cdd932793503 100644
--- a/pkg/analyzer/lib/src/summary/summarize_const_expr.dart
+++ b/pkg/analyzer/lib/src/summary/summarize_const_expr.dart
@@ -275,12 +275,12 @@ abstract class AbstractConstExprSerializer {
void _pushInt(int value) {
assert(value >= 0);
- if (value >= (1 << 32)) {
+ if (value >= 0x100000000) {
int numOfComponents = 0;
ints.add(numOfComponents);
void pushComponents(int value) {
- if (value >= (1 << 32)) {
- pushComponents(value >> 32);
+ if (value >= 0x100000000) {
+ pushComponents(value ~/ 0x100000000);
}
numOfComponents++;
ints.add(value & 0xFFFFFFFF);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698