Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Issue 2711843002: Removed TODO(crbug.com/677354). (Closed)

Created:
3 years, 10 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 10 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, Eugene But (OOO till 7-30)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removed TODO(crbug.com/677354). |WKNavigation| argument is null_unspecified, so it is expected that navigation object can be null. BUG=677354 Review-Url: https://codereview.chromium.org/2711843002 Cr-Commit-Position: refs/heads/master@{#452353} Committed: https://chromium.googlesource.com/chromium/src/+/afa9f1d9f15899f52ec07b4e23c2e6cee0d17240

Patch Set 1 #

Patch Set 2 : Removed extra DCHECK #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M ios/web/web_state/ui/crw_wk_navigation_states.mm View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-02-23 00:42:47 UTC) #3
kkhorimoto
lgtm
3 years, 10 months ago (2017-02-23 01:20:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711843002/20001
3 years, 10 months ago (2017-02-23 02:30:27 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 02:36:43 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/afa9f1d9f15899f52ec07b4e23c2...

Powered by Google App Engine
This is Rietveld 408576698