MD Settings: Add "Auto Open" setting to Downloads C++ handler.

MD Settings: Add "Auto Open" setting to Downloads C++ handler.

BUG=692662
Review-Url: https://codereview.chromium.org/2711823002
Cr-Commit-Position: refs/heads/master@{#453035}
Committed: https://chromium.googlesource.com/chromium/src/+/b8ab8bd804ea8206e8f11ed10c6ea93a9b0dffcf

[tommycli, 2017-02-22 22:05:10]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-22 22:05:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-02-22 22:33:49]

tommycli@chromium.org changed reviewers:
+ dbeam@chromium.org

[tommycli, 2017-02-22 22:33:49]

dbeam: PTAL, thanks!

[tommycli, 2017-02-22 22:34:16]

On 2017/02/22 22:33:49, tommycli wrote:
> dbeam: PTAL, thanks!

Parts of the .cc file copied from browser_options_handler.cc in Options.

[commit-bot: I haz the power, 2017-02-23 02:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-23 02:37:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Dan Beam, 2017-02-23 03:06:32]

lgtm w/question

https://codereview.chromium.org/2711823002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/downloads_handler.cc (right):

https://codereview.chromium.org/2711823002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/downloads_handler.cc:46:
pref_registrar_.Init(prefs);
nit: pref_register_.Init(profile_->GetPrefs())

https://codereview.chromium.org/2711823002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/downloads_handler_unittest.cc (right):

https://codereview.chromium.org/2711823002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/downloads_handler_unittest.cc:71: // Must be
allocated on the heap for proper shutdown.
why is this?  shouldn't these be fairly easy to destruct as long as the order is
predictable and correct?

[tommycli, 2017-02-24 19:02:42]

Thanks!

https://codereview.chromium.org/2711823002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/downloads_handler.cc (right):

https://codereview.chromium.org/2711823002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/downloads_handler.cc:46:
pref_registrar_.Init(prefs);
On 2017/02/23 03:06:32, Dan Beam wrote:
> nit: pref_register_.Init(profile_->GetPrefs())

Done.

https://codereview.chromium.org/2711823002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/downloads_handler_unittest.cc (right):

https://codereview.chromium.org/2711823002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/downloads_handler_unittest.cc:71: // Must be
allocated on the heap for proper shutdown.
On 2017/02/23 03:06:32, Dan Beam wrote:
> why is this?  shouldn't these be fairly easy to destruct as long as the order
is
> predictable and correct?

Hey I updated the comment. This object is destroyed by |profile_|, so we have to
make sure we don't double-destroy it. (Also once we give this obj to profile_,
there is no way to make profile_ return ownership to us)

A similar pattern is used here:
https://cs.chromium.org/chromium/src/chrome/browser/browsing_data/browsing_da...

[tommycli, 2017-02-24 19:02:47]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 19:03:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-02-24 19:25:53]

The CQ bit was unchecked by tommycli@chromium.org

[tommycli, 2017-02-24 19:25:54]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-02-24 19:25:54]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2711823002/#ps20001
(title: "address dbeam comments")

[commit-bot: I haz the power, 2017-02-24 19:26:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 21:42:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 21:42:14]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2017-02-24 23:21:00]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-24 23:21:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 00:47:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-25 00:47:52]

Dry run: This issue passed the CQ dry run.

[tommycli, 2017-02-25 01:11:17]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2017-02-25 01:11:17]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2711823002/#ps40001
(title: "fix teardown")

[commit-bot: I haz the power, 2017-02-25 01:11:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-25 01:17:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487985077394670,
"parent_rev": "7790fd7691ce33cf531335bf0c5d703fea33c0d9", "commit_rev":
"b8ab8bd804ea8206e8f11ed10c6ea93a9b0dffcf"}

[commit-bot: I haz the power, 2017-02-25 01:19:04]

Description was changed from

==========
MD Settings: Add "Auto Open" setting to Downloads C++ handler.

BUG=692662
==========

to

==========
MD Settings: Add "Auto Open" setting to Downloads C++ handler.

BUG=692662

Review-Url: https://codereview.chromium.org/2711823002
Cr-Commit-Position: refs/heads/master@{#453035}
Committed:
https://chromium.googlesource.com/chromium/src/+/b8ab8bd804ea8206e8f11ed10c6e...
==========

[commit-bot: I haz the power, 2017-02-25 01:19:05]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b8ab8bd804ea8206e8f11ed10c6e...