Add a histogram to track how many server configs has been persisted

Add a histogram to track how many server configs has been persisted
into disk on Android.

BUG=670519
Review-Url: https://codereview.chromium.org/2711803003
Cr-Commit-Position: refs/heads/master@{#452647}
Committed: https://chromium.googlesource.com/chromium/src/+/2f8faeaffdf9e93caaf0dab7e99d733e3d6278d3

[Zhongyi Shi, 2017-02-23 00:08:12]

zhongyi@chromium.org changed reviewers:
+ asvitkine@chromium.org, rch@chromium.org

[Ryan Hamilton, 2017-02-23 00:10:19]

lgtm

[Zhongyi Shi, 2017-02-23 18:18:31]

Alexei, friendly ping! PTAL, thanks!

[Alexei Svitkine (slow), 2017-02-23 18:23:41]

https://codereview.chromium.org/2711803003/diff/1/net/http/http_server_proper...
File net/http/http_server_properties_manager.cc (right):

https://codereview.chromium.org/2711803003/diff/1/net/http/http_server_proper...
net/http/http_server_properties_manager.cc:778:
UMA_HISTOGRAM_COUNTS("Net.CountOfQuicServerInfos",
Nit: We now recommend to use UMA_HISTOGRAM_COUNTS_<max>() macros instead.

UMA_HISTOGRAM_COUNTS() corresponds to UMA_HISTOGRAM_COUNTS_1M() - so if that's
appropriate use that, but I suspect in this case you might have better results
with a smaller maximum like 10k or something.

https://codereview.chromium.org/2711803003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2711803003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:31427: +<histogram
name="Net.CountOfQuicServerInfos">
Nit: Add units="configs" or similar

[Zhongyi Shi, 2017-02-23 20:36:22]

PTAL, thanks!

https://codereview.chromium.org/2711803003/diff/1/net/http/http_server_proper...
File net/http/http_server_properties_manager.cc (right):

https://codereview.chromium.org/2711803003/diff/1/net/http/http_server_proper...
net/http/http_server_properties_manager.cc:778:
UMA_HISTOGRAM_COUNTS("Net.CountOfQuicServerInfos",
On 2017/02/23 18:23:41, Alexei Svitkine (slow) wrote:
> Nit: We now recommend to use UMA_HISTOGRAM_COUNTS_<max>() macros instead.
> 
> UMA_HISTOGRAM_COUNTS() corresponds to UMA_HISTOGRAM_COUNTS_1M() - so if that's
> appropriate use that, but I suspect in this case you might have better results
> with a smaller maximum like 10k or something.

Done.

https://codereview.chromium.org/2711803003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2711803003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:31427: +<histogram
name="Net.CountOfQuicServerInfos">
On 2017/02/23 18:23:41, Alexei Svitkine (slow) wrote:
> Nit: Add units="configs" or similar

Done.

[Alexei Svitkine (slow), 2017-02-23 20:53:13]

lgtm

[Zhongyi Shi, 2017-02-23 20:56:37]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2017-02-23 20:56:37]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2711803003/#ps20001
(title: "address Alexei's comments")

[commit-bot: I haz the power, 2017-02-23 20:57:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 22:04:22]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487883397331340,
"parent_rev": "f087f34d91e04c8890502ac10dfb371da1a0f20c", "commit_rev":
"2f8faeaffdf9e93caaf0dab7e99d733e3d6278d3"}

[commit-bot: I haz the power, 2017-02-23 22:04:59]

Description was changed from

==========
Add a histogram to track how many server configs has been persisted
into disk on Android.

BUG=670519
==========

to

==========
Add a histogram to track how many server configs has been persisted
into disk on Android.

BUG=670519

Review-Url: https://codereview.chromium.org/2711803003
Cr-Commit-Position: refs/heads/master@{#452647}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f8faeaffdf9e93caaf0dab7e99d...
==========

[commit-bot: I haz the power, 2017-02-23 22:05:00]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2f8faeaffdf9e93caaf0dab7e99d...