Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 2711793002: [Merge to M57] Revert of Signin screen and locked screen status area focus advancing (https://coder… (Closed)

Created:
3 years, 10 months ago by Qiang(Joe) Xu
Modified:
3 years, 10 months ago
Reviewers:
xiyuan, achuithb, stevenjb
CC:
chromium-reviews, alemate+watch_chromium.org, sadrul, achuith+watch_chromium.org, oshima+watch_chromium.org, kalyank, davemoore+watch_chromium.org
Target Ref:
refs/pending/branch-heads/2987
Project:
chromium
Visibility:
Public.

Description

[Merge to M57] Revert of Signin screen and locked screen status area focus advancing (https://codereview.chromium.org/2295843006) Revert reason: Revert to get rid of the crash before having a proper fix. TBR=xiyuan@chromium.org, stevenjb@chromium.org, achuith@chromium.org BUG=692784 BUG=468969 TEST=crash doesn't happen now, leaving the bug in crbug.com/468969 comment 7 reopen. Review-Url: https://codereview.chromium.org/2709593002 Cr-Commit-Position: refs/heads/master@{#451983} (cherry picked from commit 26f01531f9e0ecd2e0cde6cf5dacb0e4b70610ce) Review-Url: https://codereview.chromium.org/2711793002 . Cr-Commit-Position: refs/branch-heads/2987@{#643} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} Committed: https://chromium.googlesource.com/chromium/src/+/7238549d0ff22bd230e3ad83b4c4508335acb507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -137 lines) Patch
M ash/common/system/status_area_widget_delegate.h View 2 chunks +0 lines, -18 lines 0 comments Download
M ash/common/system/status_area_widget_delegate.cc View 1 chunk +1 line, -19 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.h View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 8 chunks +5 lines, -89 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Qiang(Joe) Xu
3 years, 10 months ago (2017-02-22 18:23:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7238549d0ff22bd230e3ad83b4c4508335acb507 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698