Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2711763007: Replace FrameLoaderClient.h with LocalFrameClient.h and rename as needed. (Closed)

Created:
3 years, 10 months ago by slangley
Modified:
3 years, 10 months ago
Reviewers:
haraken, joelhockey
CC:
blink-frame-reviews_chromium.org, blink-reviews, chromium-reviews, dcheng, mlamouri+watch-blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace FrameLoaderClient.h with LocalFrameClient.h and replace usage of FrameLoaderClient with LocalFrameClient for files located under third_party/WebKit/Source/core/frame. *** This is just a rename CL - There are no logic changes *** BUG=694773 Review-Url: https://codereview.chromium.org/2711763007 Cr-Commit-Position: refs/heads/master@{#453069} Committed: https://chromium.googlesource.com/chromium/src/+/b39e4cecb07231262bbce0ab825c31b1fe9bc76d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M third_party/WebKit/Source/core/frame/Frame.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/FrameView.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/History.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/frame/VisualViewport.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 3 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
slangley
3 years, 10 months ago (2017-02-24 06:04:41 UTC) #3
joelhockey
lgtm
3 years, 10 months ago (2017-02-24 06:15:04 UTC) #4
slangley
haraken@ - please take a look.
3 years, 10 months ago (2017-02-24 08:39:07 UTC) #6
haraken
LGTM
3 years, 10 months ago (2017-02-24 08:46:08 UTC) #7
haraken
The first line of the CL description should be a title of the CL. "Replace ...
3 years, 10 months ago (2017-02-24 08:46:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711763007/1
3 years, 10 months ago (2017-02-25 02:27:48 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-25 04:46:19 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b39e4cecb07231262bbce0ab825c...

Powered by Google App Engine
This is Rietveld 408576698