Revert of (Set)IsOverridingUserAgent should be called on VisibleItem

Revert of (Set)IsOverridingUserAgent should be called on VisibleItem (patchset #9 id:180001 of https://codereview.chromium.org/2711683002/ )

Reason for revert:
Causes ToolsPopupMenuTestCase.testToolsMenuRequestDesktopNetwork to fail with error:
../../ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm:109: error: -[ToolsPopupMenuTestCase testToolsMenuRequestDesktopNetwork] : Exception: NoMatchingElementException

Original issue's description:
> (Set)IsOverridingUserAgent should be called on VisibleItem
> 
> As explained in the associated bug, it always makes sense to call
> IsOverridingUserAgent() and SetIsOverridingUserAgent() on visible item
> instead of current item. Thus this CL changes CurrentItem to VisibleItem
> wherever necessary.
> 
> Besides, this CL also does the following refactoring to have 
> NavigationManagerImpl encapsulate VisibleItem for calling
> (Set)IsOverridingUserAgent() to provide one more layer of abstraction.
> 
> BUG=693794
> 
> Review-Url: https://codereview.chromium.org/2711683002
> Cr-Commit-Position: refs/heads/master@{#452570}
> Committed: https://chromium.googlesource.com/chromium/src/+/21359189a7883d38a531e8681cc250bdf301fa85

TBR=eugenebut@chromium.org,kkhorimoto@chromium.org,liaoyuke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=693794
Review-Url: https://codereview.chromium.org/2711733007
Cr-Commit-Position: refs/heads/master@{#452713}
Committed: https://chromium.googlesource.com/chromium/src/+/55a8e3f7414855960a20135217d32de930466f3d

[gchatz, 2017-02-24 01:44:08]

The CQ bit was checked by gchatz@chromium.org

[gchatz, 2017-02-24 01:44:08]

Created Revert of (Set)IsOverridingUserAgent should be called on VisibleItem

[commit-bot: I haz the power, 2017-02-24 01:44:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 01:44:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-24 01:44:40]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
Committers are members of the group "project-chromium-committers".
Note that this has nothing to do with OWNERS files.

[Eugene But (OOO till 7-30), 2017-02-24 01:52:10]

lgtm

[gchatz, 2017-02-24 01:52:26]

The CQ bit was checked by gchatz@chromium.org

[commit-bot: I haz the power, 2017-02-24 01:52:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-24 01:54:08]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487901146339460, "parent_rev":
"188b7bdc8292a7b740f7caa3d26bfd89aac5a924", "commit_rev":
"55a8e3f7414855960a20135217d32de930466f3d"}

[liaoyuke, 2017-02-24 01:54:15]

lgtm

On Thu, Feb 23, 2017 at 5:52 PM commit-bot@chromium.org via
codereview.chromium.org <reply@chromiumcodereview-hr.appspotmail.com> wrote:

> CQ is trying da patch. Follow status at
>
>
>
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
>
>
> https://codereview.chromium.org/2711733007/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[commit-bot: I haz the power, 2017-02-24 01:54:44]

Description was changed from

==========
Revert of (Set)IsOverridingUserAgent should be called on VisibleItem (patchset
#9 id:180001 of https://codereview.chromium.org/2711683002/ )

Reason for revert:
Causes ToolsPopupMenuTestCase.testToolsMenuRequestDesktopNetwork to fail with
error:
../../ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm:109: error:
-[ToolsPopupMenuTestCase testToolsMenuRequestDesktopNetwork] : Exception:
NoMatchingElementException

Original issue's description:
> (Set)IsOverridingUserAgent should be called on VisibleItem
> 
> As explained in the associated bug, it always makes sense to call
> IsOverridingUserAgent() and SetIsOverridingUserAgent() on visible item
> instead of current item. Thus this CL changes CurrentItem to VisibleItem
> wherever necessary.
> 
> Besides, this CL also does the following refactoring to have 
> NavigationManagerImpl encapsulate VisibleItem for calling
> (Set)IsOverridingUserAgent() to provide one more layer of abstraction.
> 
> BUG=693794
> 
> Review-Url: https://codereview.chromium.org/2711683002
> Cr-Commit-Position: refs/heads/master@{#452570}
> Committed:
https://chromium.googlesource.com/chromium/src/+/21359189a7883d38a531e8681cc2...

TBR=eugenebut@chromium.org,kkhorimoto@chromium.org,liaoyuke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=693794
==========

to

==========
Revert of (Set)IsOverridingUserAgent should be called on VisibleItem (patchset
#9 id:180001 of https://codereview.chromium.org/2711683002/ )

Reason for revert:
Causes ToolsPopupMenuTestCase.testToolsMenuRequestDesktopNetwork to fail with
error:
../../ios/chrome/browser/ui/tools_menu/tools_popup_menu_egtest.mm:109: error:
-[ToolsPopupMenuTestCase testToolsMenuRequestDesktopNetwork] : Exception:
NoMatchingElementException

Original issue's description:
> (Set)IsOverridingUserAgent should be called on VisibleItem
> 
> As explained in the associated bug, it always makes sense to call
> IsOverridingUserAgent() and SetIsOverridingUserAgent() on visible item
> instead of current item. Thus this CL changes CurrentItem to VisibleItem
> wherever necessary.
> 
> Besides, this CL also does the following refactoring to have 
> NavigationManagerImpl encapsulate VisibleItem for calling
> (Set)IsOverridingUserAgent() to provide one more layer of abstraction.
> 
> BUG=693794
> 
> Review-Url: https://codereview.chromium.org/2711683002
> Cr-Commit-Position: refs/heads/master@{#452570}
> Committed:
https://chromium.googlesource.com/chromium/src/+/21359189a7883d38a531e8681cc2...

TBR=eugenebut@chromium.org,kkhorimoto@chromium.org,liaoyuke@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=693794

Review-Url: https://codereview.chromium.org/2711733007
Cr-Commit-Position: refs/heads/master@{#452713}
Committed:
https://chromium.googlesource.com/chromium/src/+/55a8e3f7414855960a20135217d3...
==========

[commit-bot: I haz the power, 2017-02-24 01:54:45]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/55a8e3f7414855960a20135217d3...