Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 2711703002: Revert of Use TaskScheduler instead of WorkerPool in v8_platform.cc. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Use TaskScheduler instead of WorkerPool in v8_platform.cc. (patchset #18 id:340001 of https://codereview.chromium.org/2610473002/ ) Reason for revert: Causing extensions_unittests to hang and take 15 minutes. BUG=694828 Original issue's description: > Use TaskScheduler instead of WorkerPool in v8_platform.cc. > > The following traits are used: > > Priority: Inherited (default) > The priority is inherited from the calling context (i.e. TaskTraits > are initialized with the priority of the current task). > > Shutdown behavior: CONTINUE_ON_SHUTDOWN > Tasks posted with this mode which have not started executing before > shutdown is initiated will never run. Tasks with this mode running at > shutdown will be ignored (the worker will not be joined). > > Note: Tasks that were previously posted to base::WorkerPool should > use this shutdown behavior because this is how base::WorkerPool > handles all its tasks. > > MayBlock(): > The task may block. > > BUG=659191 > > Review-Url: https://codereview.chromium.org/2610473002 > Cr-Commit-Position: refs/heads/master@{#449976} > Committed: https://chromium.googlesource.com/chromium/src/+/b83be4ca0e00b50b17619adf7f7de275455e9852 TBR=jochen@chromium.org,fdoray@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=659191 Review-Url: https://codereview.chromium.org/2711703002 Cr-Commit-Position: refs/heads/master@{#452058} Committed: https://chromium.googlesource.com/chromium/src/+/4df731b9954e2973ae8e206185f3de4556a806be

Patch Set 1 #

Patch Set 2 : another patchset to kick off tryjobs #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -129 lines) Patch
M chrome/test/base/v8_unit_test.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M content/public/test/render_view_test.h View 1 2 chunks +0 lines, -8 lines 0 comments Download
M content/renderer/pepper/host_var_tracker_unittest.cc View 1 2 chunks +0 lines, -6 lines 0 comments Download
M content/test/blink_test_environment.cc View 1 3 chunks +11 lines, -14 lines 0 comments Download
M extensions/renderer/api_binding_test.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M extensions/renderer/gc_callback_unittest.cc View 1 3 chunks +3 lines, -7 lines 0 comments Download
M extensions/renderer/module_system_test.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M gin/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M gin/shell/gin_main.cc View 1 2 chunks +21 lines, -33 lines 0 comments Download
M gin/shell_runner_unittest.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M gin/test/file_runner.cc View 1 2 chunks +0 lines, -2 lines 0 comments Download
M gin/test/v8_test.h View 1 2 chunks +0 lines, -6 lines 0 comments Download
M gin/v8_platform.cc View 1 3 chunks +15 lines, -12 lines 0 comments Download
M mojo/edk/js/tests/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M mojo/edk/js/tests/js_to_cpp_tests.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M net/proxy/proxy_resolver_v8_tracing_unittest.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M net/proxy/proxy_resolver_v8_tracing_wrapper_unittest.cc View 1 2 chunks +0 lines, -5 lines 0 comments Download
M net/proxy/proxy_resolver_v8_unittest.cc View 1 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 19 (10 generated)
jam
Created Revert of Use TaskScheduler instead of WorkerPool in v8_platform.cc.
3 years, 10 months ago (2017-02-22 00:26:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711703002/1
3 years, 10 months ago (2017-02-22 00:27:39 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) chromeos_amd64-generic_chromium_compile_only_ng on ...
3 years, 10 months ago (2017-02-22 02:30:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711703002/1
3 years, 10 months ago (2017-02-22 03:15:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711703002/1
3 years, 10 months ago (2017-02-22 04:31:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711703002/240001
3 years, 10 months ago (2017-02-22 04:35:43 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/394866)
3 years, 10 months ago (2017-02-22 07:21:03 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711703002/240001
3 years, 10 months ago (2017-02-22 14:44:02 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 15:25:41 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:240001) as
https://chromium.googlesource.com/chromium/src/+/4df731b9954e2973ae8e206185f3...

Powered by Google App Engine
This is Rietveld 408576698