Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2711683002: (Set)IsOverridingUserAgent should be called on VisibleItem (Closed)
Patch Set: Rename function names Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ios/chrome/browser/tabs/tab.h ('K') | « ios/chrome/browser/tabs/tab.h ('k') | ios/chrome/browser/ui/browser_view_controller.mm » ('j') | ios/web/navigation/navigation_manager_impl.mm » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab.mm
diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm
index a6eda18221461e7f4268aae932b9dd11ecab1fdc..77315f6fbb22a705ac2b02dbb3dc75f49b9d451d 100644
--- a/ios/chrome/browser/tabs/tab.mm
+++ b/ios/chrome/browser/tabs/tab.mm
@@ -1567,13 +1567,12 @@ - (void)openAppStore:(NSString*)appId {
[storeKitLauncher_ openAppStore:appId];
}
-- (BOOL)useDesktopUserAgent {
- web::NavigationItem* currentItem = self.currentNavigationItem;
- return currentItem && currentItem->IsOverridingUserAgent();
+- (BOOL)isUsingDesktopUserAgent {
+ return [self navigationManager]->IsUsingDesktopUserAgent();
}
- (void)enableDesktopUserAgent {
- DCHECK_EQ(self.useDesktopUserAgent, NO);
+ DCHECK_EQ(self.usingDesktopUserAgent, NO);
DCHECK([self navigationManager]);
[self navigationManager]->OverrideDesktopUserAgentForNextPendingItem();
}
« ios/chrome/browser/tabs/tab.h ('K') | « ios/chrome/browser/tabs/tab.h ('k') | ios/chrome/browser/ui/browser_view_controller.mm » ('j') | ios/web/navigation/navigation_manager_impl.mm » ('J')

Powered by Google App Engine
This is Rietveld 408576698