(Set)IsOverridingUserAgent should be called on VisibleItem

ios/chrome/browser/tabs/tab.h

Index: ios/chrome/browser/tabs/tab.h
diff --git a/ios/chrome/browser/tabs/tab.h b/ios/chrome/browser/tabs/tab.h
index 163c827457e667e8de1a2aa9fe11a39a6add8bf8..4d126964649d334ee1d040499b2def5c8caeed4b 100644
--- a/ios/chrome/browser/tabs/tab.h
+++ b/ios/chrome/browser/tabs/tab.h
@@ -133,7 +133,11 @@ extern NSString* const kProxyPassthroughHeaderValue;
 @property(nonatomic, assign) id<TabHeadersDelegate> tabHeadersDelegate;
 @property(nonatomic, assign) id<TabSnapshottingDelegate>
     tabSnapshottingDelegate;
-@property(nonatomic, readonly) BOOL useDesktopUserAgent;
+
+// Whether or not desktop user agent is used for the currently loaded page.
+@property(nonatomic, readonly, getter=isUsingDesktopUserAgent)

[Eugene But (OOO till 7-30), 2017/02/22 21:57:41]

Should this be usesUsingDesktopUserAgent ?

"BOOL uses" name can be found in UIKit and Foundation:
BOOL usesFontLeading
BOOL usesEvenOddFillRule
BOOL usesMetricSystem
BOOL usesGroupingSeparator
BOOL usesSignificantDigits
BOOL usesStrongWriteBarrier
BOOL usesWeakReadAndWriteBarriers

while "BOOL using" is in never used in those frameworks.

[kkhorimoto, 2017/02/22 22:54:15]

I'm fine with "uses" or "using", as long as it's not "useDesktopUserAgent" :)

[liaoyuke, 2017/02/22 23:48:31]

Done.

[liaoyuke, 2017/02/22 23:48:31]

Acknowledged.

+    BOOL usingDesktopUserAgent;
+
 @property(nonatomic, assign) id<StoreKitLauncher> storeKitLauncher;
 @property(nonatomic, assign) id<FullScreenControllerDelegate>
     fullScreenControllerDelegate;