(Set)IsOverridingUserAgent should be called on VisibleItem

ios/web/navigation/navigation_manager_impl.h

Index: ios/web/navigation/navigation_manager_impl.h
diff --git a/ios/web/navigation/navigation_manager_impl.h b/ios/web/navigation/navigation_manager_impl.h
index 11663bd8a2d402c64e304fc04f87860d430cc48d..fd3f6a26e455b00ab074c1445eabcfdac5d12ad7 100644
--- a/ios/web/navigation/navigation_manager_impl.h
+++ b/ios/web/navigation/navigation_manager_impl.h
@@ -143,7 +143,16 @@ class NavigationManagerImpl : public NavigationManager {
   void GoForward() override;
   void GoToIndex(int index) override;
   void Reload(bool check_for_reposts) override;
-  void OverrideDesktopUserAgentForNextPendingItem() override;
+
+  // Whether or not desktop user agent is used for the currently loaded page.
+  // Returns true, if use a desktop user agent and false for a mobile one.
+  bool GetUseDesktopUserAgent() const;

[kkhorimoto, 2017/02/22 01:08:40]

This is similarly confusingly named.  Howe about "IsUsingDesktopUserAgent()"?

[liaoyuke, 2017/02/22 01:37:43]

Given that Android uses this name, do we still want to change it?

[kkhorimoto, 2017/02/22 01:54:33]

Yes, I think we should change it.

+
+  // Forces the pending item to be loaded using desktop user agent. Note that
+  // the pending item may or may not already exist.
+  // TODO(crbug.com/692303): Remove this when overriding the user agent doesn't
+  // create a new NavigationItem.
+  void OverrideDesktopUserAgentForNextPendingItem();

[kkhorimoto, 2017/02/22 01:08:40]

Since these functions are called by Tab (i.e. in the Chrome layer), they need to
be in NavigationManager instead of NavigationManagerImpl.  Currently, Tab
includes the NavigationManagerImpl header, but eventually it will depend only on
NavigationManager.  Please update the CL description after changing this back to
the public interface.

[liaoyuke, 2017/02/22 01:37:43]

Got it. Thank you for explaining.

 
   // Returns the current list of transient url rewriters, passing ownership to
   // the caller.