(Set)IsOverridingUserAgent should be called on VisibleItem

ios/web/navigation/navigation_manager_impl.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
 #define IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_
 
 #include <stddef.h>
 
 #include <memory>
@@ skipping 125 matching lines @@
   int GetPendingItemIndex() const override;
   int GetLastCommittedItemIndex() const override;
   bool RemoveItemAtIndex(int index) override;
   bool CanGoBack() const override;
   bool CanGoForward() const override;
   bool CanGoToOffset(int offset) const override;
   void GoBack() override;
   void GoForward() override;
   void GoToIndex(int index) override;
   void Reload(bool check_for_reposts) override;
-  void OverrideDesktopUserAgentForNextPendingItem() override;
+
+  // Whether or not desktop user agent is used for the currently loaded page.
+  // Returns true, if use a desktop user agent and false for a mobile one.
+  bool GetUseDesktopUserAgent() const;

[kkhorimoto, 2017/02/22 01:08:40]

This is similarly confusingly named.  Howe about "IsUsingDesktopUserAgent()"?

[liaoyuke, 2017/02/22 01:37:43]

Given that Android uses this name, do we still want to change it?

[kkhorimoto, 2017/02/22 01:54:33]

Yes, I think we should change it.

+
+  // Forces the pending item to be loaded using desktop user agent. Note that
+  // the pending item may or may not already exist.
+  // TODO(crbug.com/692303): Remove this when overriding the user agent doesn't
+  // create a new NavigationItem.
+  void OverrideDesktopUserAgentForNextPendingItem();

[kkhorimoto, 2017/02/22 01:08:40]

Since these functions are called by Tab (i.e. in the Chrome layer), they need to
be in NavigationManager instead of NavigationManagerImpl.  Currently, Tab
includes the NavigationManagerImpl header, but eventually it will depend only on
NavigationManager.  Please update the CL description after changing this back to
the public interface.

[liaoyuke, 2017/02/22 01:37:43]

Got it. Thank you for explaining.

 
   // Returns the current list of transient url rewriters, passing ownership to
   // the caller.
   // TODO(crbug.com/546197): remove once NavigationItem creation occurs in this
   // class.
   std::unique_ptr<std::vector<BrowserURLRewriter::URLRewriter>>
   GetTransientURLRewriters();
 
   // Called to reset the transient url rewriter list.
   void RemoveTransientURLRewriters();
@@ skipping 40 matching lines @@
   // List of transient url rewriters added by |AddTransientURLRewriter()|.
   std::unique_ptr<std::vector<BrowserURLRewriter::URLRewriter>>
       transient_url_rewriters_;
 
   DISALLOW_COPY_AND_ASSIGN(NavigationManagerImpl);
 };
 
 }  // namespace web
 
 #endif  // IOS_WEB_NAVIGATION_NAVIGATION_MANAGER_IMPL_H_