Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(995)

Issue 2711633002: blink clang plugin: Fix some Winconsistent-missing-override warnings (Closed)

Created:
3 years, 10 months ago by Nico
Modified:
3 years, 10 months ago
Reviewers:
sof
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

blink clang plugin: Fix some Winconsistent-missing-override warnings Also insert override in places where it's been consistenty missing. No intended behavior change. BUG=none Review-Url: https://codereview.chromium.org/2711633002 Cr-Commit-Position: refs/heads/master@{#452043} Committed: https://chromium.googlesource.com/chromium/src/+/2b02351f4bd399714415d786e8b931f2bb14099d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -46 lines) Patch
M tools/clang/blink_gc_plugin/Edge.h View 4 chunks +46 lines, -46 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Nico
3 years, 10 months ago (2017-02-21 22:28:49 UTC) #2
sof
lgtm
3 years, 10 months ago (2017-02-22 06:23:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711633002/1
3 years, 10 months ago (2017-02-22 14:41:35 UTC) #5
commit-bot: I haz the power
3 years, 10 months ago (2017-02-22 14:49:22 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2b02351f4bd399714415d786e8b9...

Powered by Google App Engine
This is Rietveld 408576698