Convert window-audioworklet.html with new Audit

Convert window-audioworklet.html with new Audit

Change the test manually to use the new Audit. The CL also simplifies
the sniffing logic for experiment runtime flag so this test can be
performed within content shell or browser.

BUG=695083
TEST=audioworklet/window-audioworklet.html

Review-Url: https://codereview.chromium.org/2711593004
Cr-Commit-Position: refs/heads/master@{#452194}
Committed: https://chromium.googlesource.com/chromium/src/+/8c28b4ec54e13b2b94cb7229b4e58f07c54e630b

[hongchan, 2017-02-22 18:51:39]

hongchan@chromium.org changed reviewers:
+ rtoy@chromium.org

[hongchan, 2017-02-22 18:51:39]

PTAL.

[Raymond Toy, 2017-02-22 19:16:22]

https://codereview.chromium.org/2711593004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/audioworklet/audioworklet-testing.js
(right):

https://codereview.chromium.org/2711593004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/audioworklet/audioworklet-testing.js:18:
};
Do we care if we're running with content shell or browser?  Can't we just check
if window.audioWorklet exists in either case?

[hongchan, 2017-02-22 19:23:38]

https://codereview.chromium.org/2711593004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/audioworklet/audioworklet-testing.js
(right):

https://codereview.chromium.org/2711593004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/audioworklet/audioworklet-testing.js:18:
};
On 2017/02/22 19:16:22, Raymond Toy wrote:
> Do we care if we're running with content shell or browser?  Can't we just
check
> if window.audioWorklet exists in either case?

When a test relies on some experimental features, other examples usually use
'internal' and 'runtimeFlag'. So I wanted to capture that somehow. It's only two
more lines of code and I would like to use it other worklet tests. Sometimes
it's useful to see where your test is actually running on.

[Raymond Toy, 2017-02-22 19:31:29]

lgtm

https://codereview.chromium.org/2711593004/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/webaudio/audioworklet/audioworklet-testing.js
(right):

https://codereview.chromium.org/2711593004/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/webaudio/audioworklet/audioworklet-testing.js:18:
};
On 2017/02/22 19:23:38, hongchan wrote:
> On 2017/02/22 19:16:22, Raymond Toy wrote:
> > Do we care if we're running with content shell or browser?  Can't we just
> check
> > if window.audioWorklet exists in either case?
> 
> When a test relies on some experimental features, other examples usually use
> 'internal' and 'runtimeFlag'. So I wanted to capture that somehow. It's only
two
> more lines of code and I would like to use it other worklet tests. Sometimes
> it's useful to see where your test is actually running on.

YAGNI?

[hongchan, 2017-02-22 19:32:44]

On 2017/02/22 19:31:29, Raymond Toy wrote:
> lgtm
> 
>
https://codereview.chromium.org/2711593004/diff/1/third_party/WebKit/LayoutTe...
> File
> third_party/WebKit/LayoutTests/webaudio/audioworklet/audioworklet-testing.js
> (right):
> 
>
https://codereview.chromium.org/2711593004/diff/1/third_party/WebKit/LayoutTe...
>
third_party/WebKit/LayoutTests/webaudio/audioworklet/audioworklet-testing.js:18:
> };
> On 2017/02/22 19:23:38, hongchan wrote:
> > On 2017/02/22 19:16:22, Raymond Toy wrote:
> > > Do we care if we're running with content shell or browser?  Can't we just
> > check
> > > if window.audioWorklet exists in either case?
> > 
> > When a test relies on some experimental features, other examples usually use
> > 'internal' and 'runtimeFlag'. So I wanted to capture that somehow. It's only
> two
> > more lines of code and I would like to use it other worklet tests. Sometimes
> > it's useful to see where your test is actually running on.
> 
> YAGNI?

Heh, but I am already using it. :)

[hongchan, 2017-02-22 19:32:53]

The CQ bit was checked by hongchan@chromium.org

[commit-bot: I haz the power, 2017-02-22 19:33:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-22 20:57:45]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1487791973226800, "parent_rev":
"3777167162feb5b4fbd24e8386e92ae92fe354c8", "commit_rev":
"8c28b4ec54e13b2b94cb7229b4e58f07c54e630b"}

[commit-bot: I haz the power, 2017-02-22 20:58:22]

Description was changed from

==========
Convert window-audioworklet.html with new Audit

Change the test manually to use the new Audit. The CL also simplifies
the sniffing logic for experiment runtime flag so this test can be
performed within content shell or browser.

BUG=695083
TEST=audioworklet/window-audioworklet.html
==========

to

==========
Convert window-audioworklet.html with new Audit

Change the test manually to use the new Audit. The CL also simplifies
the sniffing logic for experiment runtime flag so this test can be
performed within content shell or browser.

BUG=695083
TEST=audioworklet/window-audioworklet.html

Review-Url: https://codereview.chromium.org/2711593004
Cr-Commit-Position: refs/heads/master@{#452194}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c28b4ec54e13b2b94cb7229b4e5...
==========

[commit-bot: I haz the power, 2017-02-22 20:58:23]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c28b4ec54e13b2b94cb7229b4e5...